From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v25 07/15] x86/VPMU: Save VPMU state for PV guests during context switch Date: Mon, 22 Jun 2015 16:14:14 +0100 Message-ID: <558842660200007800087AA0@mail.emea.novell.com> References: <1434739486-1611-1-git-send-email-boris.ostrovsky@oracle.com> <1434739486-1611-8-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1434739486-1611-8-git-send-email-boris.ostrovsky@oracle.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: kevin.tian@intel.com, andrew.cooper3@citrix.com, dietmar.hahn@ts.fujitsu.com, xen-devel@lists.xen.org, Aravind.Gopalakrishnan@amd.com, suravee.suthikulpanit@amd.com, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org >>> On 19.06.15 at 20:44, wrote: > Save VPMU state during context switch for both HVM and PV(H) guests. > > A subsequent patch ("x86/VPMU: NMI-based VPMU support") will make it possible > for vpmu_switch_to() to call vmx_vmcs_try_enter()->vcpu_pause() which needs > is_running to be correctly set/cleared. To prepare for that, call > context_saved() > before vpmu_switch_to() is executed. (Note that while this change could have > been dalayed until that later patch, the changes are harmless to existing > code > and so we do it here) > > Signed-off-by: Boris Ostrovsky > > --- > Changes in v25: > * Replaced is_hvm_vcpu with is_hvm_domain to be consistent with recent changes > to context_switch() That's not really a change, but just a re-base (your code doesn't add any new uses), so imo doesn't invalidate previous ack/reviews. I.e. Reviewed-by: Jan Beulich