Re: [PATCH RFC 3/4] xen: implement SCHEDOP_soft_reset

From: "Jan Beulich" <JBeulich@suse.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Olaf Hering <olaf@aepfle.de>, Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Julien Grall <julien.grall@linaro.org>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Andrew Jones <drjones@redhat.com>, Tim Deegan <tim@xen.org>,
	David Vrabel <david.vrabel@citrix.com>,
	xen-devel@lists.xenproject.org,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>,
	Keir Fraser <keir@xen.org>
Subject: Re: [PATCH RFC 3/4] xen: implement SCHEDOP_soft_reset
Date: Mon, 22 Jun 2015 17:06:18 +0100	[thread overview]
Message-ID: <55884E9A0200007800087B2C@mail.emea.novell.com> (raw)
In-Reply-To: <87r3p391hh.fsf@vitty.brq.redhat.com>

>>> On 22.06.15 at 18:00, <vkuznets@redhat.com> wrote:
> "Jan Beulich" <JBeulich@suse.com> writes:
> 
>>>>> On 03.06.15 at 15:35, <vkuznets@redhat.com> wrote:
>>> @@ -1129,8 +1129,9 @@ void unmap_vcpu_info(struct vcpu *v)
>>>      mfn = v->vcpu_info_mfn;
>>>      unmap_domain_page_global((void *)
>>>                               ((unsigned long)v->vcpu_info & PAGE_MASK));
>>> -
>>> -    v->vcpu_info = &dummy_vcpu_info;
>>> +    v->vcpu_info = ((v->vcpu_id < XEN_LEGACY_MAX_VCPUS)
>>> +                    ? (vcpu_info_t *)&shared_info(d, vcpu_info[v->vcpu_id])
>>
>> Is this cast really needed?
>>
> 
> Without it my gcc-4.8.3 complains:
> 
> domain.c: In function ‘unmap_vcpu_info’:
> domain.c:1158:21: error: pointer type mismatch in conditional expression 
> [-Werror]
>                      : &dummy_vcpu_info);
>                      ^
> cc1: all warnings being treated as errors

Which is the kind of warning one normally should _not_ work
around by adding a cast.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel