From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH v4 RFC 6/6] x86/MSI: properly track guest
 masking requests
Date: Thu, 25 Jun 2015 09:04:42 +0100
Message-ID: <558BD23A0200007800089597@mail.emea.novell.com>
References: <558839ED02000078000879FE@mail.emea.novell.com>
	<55883D290200007800087A67@mail.emea.novell.com>
	<558AE7DD.6090908@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <JBeulich@suse.com>) id 1Z829P-0006LP-Ib
	for xen-devel@lists.xenproject.org; Thu, 25 Jun 2015 08:04:47 +0000
In-Reply-To: <558AE7DD.6090908@citrix.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

>>> On 24.06.15 at 19:24, <andrew.cooper3@citrix.com> wrote:
> On 22/06/15 15:51, Jan Beulich wrote:
>> --- a/xen/arch/x86/msi.c
>> +++ b/xen/arch/x86/msi.c
>> @@ -1308,6 +1308,39 @@ printk("%04x:%02x:%02x.%u: MSI-X %03x:%u
>>          return 1;
>>      }
>>  
>> +    entry = find_msi_entry(pdev, -1, PCI_CAP_ID_MSI);
>> +    if ( entry && entry->msi_attrib.maskbit )
>> +    {
>> +        uint16_t cntl;
>> +        uint32_t unused;
>> +
>> +        pos = entry->msi_attrib.pos;
>> +        if ( reg < pos || reg >= entry->msi.mpos + 8 )
>> +            return 0;
>> +printk("%04x:%02x:%02x.%u: MSI %03x:%u->%04x\n", seg, bus, slot, func, reg, size, *data);//temp
>> +
>> +        if ( reg == msi_control_reg(pos) )
>> +            return size == 2 ? 1 : -EACCES;
>> +        if ( reg < entry->msi.mpos || reg >= entry->msi.mpos + 4 || size != 4 )
>> +            return -EACCES;
> 
> Can we avoid using EACCES to avoid confusing it with a mismatched tools
> version?

What other suitable error code would you see here? I'm not sure
we want this error code to be reserved for exactly one purpose,
the more that here we're on a path that will never has this error
code returned to the guest (and even less so via a domctl/sysctl,
which would be the primary mismatched-tools-version candidates).

It's also odd that you ask for this here, when patch 2 has a use
of this error code too.

Jan