From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v3 01/32] libxc: split x86 HVM setup_guest into smaller logical functions Date: Mon, 6 Jul 2015 11:45:13 +0100 Message-ID: <559A5C39.2090506@citrix.com> References: <1435923310-9019-1-git-send-email-roger.pau@citrix.com> <1435923310-9019-2-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZC3tr-0002iR-QG for xen-devel@lists.xenproject.org; Mon, 06 Jul 2015 10:45:23 +0000 In-Reply-To: <1435923310-9019-2-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org T24gMDMvMDcvMTUgMTI6MzQsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToKPiBUaGlzIGlzIGp1c3Qg YSBwcmVwYXJhdG9yeSBjaGFuZ2UgdG8gY2xlYW4gdXAgdGhlIGNvZGUgaW4gc2V0dXBfZ3Vlc3Qu Cj4gU2hvdWxkIG5vdCBpbnRyb2R1Y2UgYW55IGZ1bmN0aW9uYWwgY2hhbmdlcy4KPgo+IFNpZ25l ZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgo+IENjOiBJ YW4gSmFja3NvbiA8aWFuLmphY2tzb25AZXUuY2l0cml4LmNvbT4KPiBDYzogU3RlZmFubyBTdGFi ZWxsaW5pIDxzdGVmYW5vLnN0YWJlbGxpbmlAZXUuY2l0cml4LmNvbT4KPiBDYzogSWFuIENhbXBi ZWxsIDxpYW4uY2FtcGJlbGxAY2l0cml4LmNvbT4KPiBDYzogV2VpIExpdSA8d2VpLmxpdTJAY2l0 cml4LmNvbT4KClJldmlld2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRy aXguY29tPiwgd2l0aCBvbmUgbm90ZS4KCj4gQEAgLTU3Niw2ICs1ODQsNDQgQEAgc3RhdGljIGlu dCBzZXR1cF9ndWVzdCh4Y19pbnRlcmZhY2UgKnhjaCwKPiAgICAgICAgICBnb3RvIGVycm9yX291 dDsKPiAgICAgIH0KPiAgCj4gKyAgICAvKiBJbnNlcnQgSk1QIDxyZWwzMj4gaW5zdHJ1Y3Rpb24g YXQgYWRkcmVzcyAweDAgdG8gcmVhY2ggZW50cnkgcG9pbnQuICovCj4gKyAgICBlbnRyeV9laXAg PSBlbGZfdXZhbCgmZWxmLCBlbGYuZWhkciwgZV9lbnRyeSk7Cj4gKyAgICBpZiAoIGVudHJ5X2Vp cCAhPSAwICkKPiArICAgIHsKPiArICAgICAgICBjaGFyICpwYWdlMCA9IHhjX21hcF9mb3JlaWdu X3JhbmdlKAo+ICsgICAgICAgICAgICB4Y2gsIGRvbSwgUEFHRV9TSVpFLCBQUk9UX1JFQUQgfCBQ Uk9UX1dSSVRFLCAwKTsKPiArICAgICAgICBpZiAoIHBhZ2UwID09IE5VTEwgKQo+ICsgICAgICAg ICAgICBnb3RvIGVycm9yX291dDsKPiArICAgICAgICBwYWdlMFswXSA9IDB4ZTk7Cj4gKyAgICAg ICAgKih1aW50MzJfdCAqKSZwYWdlMFsxXSA9IGVudHJ5X2VpcCAtIDU7Cj4gKyAgICAgICAgbXVu bWFwKHBhZ2UwLCBQQUdFX1NJWkUpOwo+ICsgICAgfQoKV2l0aCB0aGlzIHNlcmllcyBldmVudHVh bGx5IGVuYWJsaW5nIERPTUNUTF9zZXR2Y3B1Y29udGV4dCBwcm9wZXJseSBmb3IKSFZNIHZjcHVz LCB0aGlzIGFib3ZlIGp1Z2dsaW5nIGNhbiBiZSByZXBsYWNlZCBieSBzZXR0aW5nIHRoZSBzdGFy dGluZwplaXAgYXBwcm9wcmlhdGVseSwgd2hpY2ggaXMgbmVhdGVyIHRoYW4gc3R1ZmZpbmcgYSBo YW5kLWNvZGVkCmluc3RydWN0aW9uIGluIGF0IDAuCgp+QW5kcmV3CgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhl bi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=