From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v3 06/32] libxc: make arch_setup_boot{init/late} xc_dom_arch hooks Date: Mon, 6 Jul 2015 13:27:53 +0100 Message-ID: <559A7449.2030705@citrix.com> References: <1435923310-9019-1-git-send-email-roger.pau@citrix.com> <1435923310-9019-7-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZC5V9-0007uw-1q for xen-devel@lists.xenproject.org; Mon, 06 Jul 2015 12:27:59 +0000 In-Reply-To: <1435923310-9019-7-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 03/07/15 12:34, Roger Pau Monne wrote: > diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c > index 6fb4aee..993954e 100644 > --- a/tools/libxc/xc_dom_x86.c > +++ b/tools/libxc/xc_dom_x86.c > @@ -926,41 +926,7 @@ static int meminit_pv(struct xc_dom_image *dom) > > /* ------------------------------------------------------------------------ */ > > -static struct xc_dom_arch xc_dom_32_pae = { > - .guest_type = "xen-3.0-x86_32p", > - .native_protocol = XEN_IO_PROTO_ABI_X86_32, > - .page_shift = PAGE_SHIFT_X86, > - .sizeof_pfn = 4, > - .alloc_magic_pages = alloc_magic_pages, > - .count_pgtables = count_pgtables_x86_32_pae, > - .setup_pgtables = setup_pgtables_x86_32_pae, > - .start_info = start_info_x86_32, > - .shared_info = shared_info_x86_32, > - .vcpu = vcpu_x86_32, > - .meminit = meminit_pv, > -}; > - > -static struct xc_dom_arch xc_dom_64 = { > - .guest_type = "xen-3.0-x86_64", > - .native_protocol = XEN_IO_PROTO_ABI_X86_64, > - .page_shift = PAGE_SHIFT_X86, > - .sizeof_pfn = 8, > - .alloc_magic_pages = alloc_magic_pages, > - .count_pgtables = count_pgtables_x86_64, > - .setup_pgtables = setup_pgtables_x86_64, > - .start_info = start_info_x86_64, > - .shared_info = shared_info_x86_64, > - .vcpu = vcpu_x86_64, > - .meminit = meminit_pv, > -}; > - > -static void __init register_arch_hooks(void) > -{ > - xc_dom_register_arch_hooks(&xc_dom_32_pae); > - xc_dom_register_arch_hooks(&xc_dom_64); > -} Instead of moving this lot twice in two consecutive patches, have patch 5 move them to their eventual location, which makes this patch much smaller. Otherwise, Reviewed-by: Andrew Cooper