From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [v7][PATCH 16/16] tools: parse to enable new rdm
 policy parameters
Date: Mon, 13 Jul 2015 17:55:27 +0800
Message-ID: <55A38B0F.1050608@intel.com>
References: <1436420047-25356-1-git-send-email-tiejun.chen@intel.com>		<1436420047-25356-17-git-send-email-tiejun.chen@intel.com>		<21918.48191.157583.452591@mariner.uk.xensource.com>		<559F60AB.2060402@intel.com>	
	<21919.40225.618413.570220@mariner.uk.xensource.com>	
	<55A38583.9080204@intel.com> <1436780431.7019.54.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1436780431.7019.54.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org, Ian Jackson <Ian.Jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 2015/7/13 17:40, Ian Campbell wrote:
> On Mon, 2015-07-13 at 17:31 +0800, Chen, Tiejun wrote:
>> I still can't understand what I'm missing here after compared to other
>> contexts inside xlu_pci_parse_bdf().
>
> Perhaps comparing to the CODING_STYLE document would help?

Looks the whole xlu_pci_parse_bdf() doesn't follow that,

                 if ( !strcmp(optkey, "msitranslate") ) {
                     pcidev->msitranslate = atoi(tok);
                 }else if ( !strcmp(optkey, "power_mgmt") ) {
                     pcidev->power_mgmt = atoi(tok);
                 }else if ( !strcmp(optkey, "permissive") ) {
                     pcidev->permissive = atoi(tok);
                 }else if ( !strcmp(optkey, "seize") ) {
                     pcidev->seize = atoi(tok);
                 }else if ( !strcmp(optkey, "rdm_policy") ) {

So I can do this as you're expecting now, but seems our change would 
make the code style very inconsistent inside this function.

Thanks
Tiejun


>
>>   So I have to paste this entirely,
>>
>>                   }else if ( !strcmp(optkey, "rdm_policy") ) {
>
> Should be:
>                   } else if (!strcmp(optkey, "rdm_policy")) {
>
> i.e. space after } before "else" and no extra spaces inside the if
> condition.
>
>>                       if ( !strcmp(tok, "strict") ) {
>
>                       if (!strcmp(tok, "strict")) {
>
> Again no spaces within the if.
>
>>                           pcidev->rdm_policy = LIBXL_RDM_RESERVE_POLICY_STRICT;
>>                       }else if ( !strcmp(tok, "relaxed") ) {
>
> Again add a space after } and remove those inside the if condition.
>
>>                           pcidev->rdm_policy = LIBXL_RDM_RESERVE_POLICY_RELAXED;
>>                       }else{
>
> Should be:
>                       } else {
>
>>                           XLU__PCI_ERR(cfg, "%s is not an valid PCI RDM
>> property"
>>                                             " policy: 'strict' or
>> 'relaxed'.",
>>                                        tok);
>>                           goto parse_error;
>>                       }
>>                   }else{
>
> and again "} else {"
>
> Ian.
>
>
>