From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH V5 0/3] Vm_event memory introspection helpers Date: Tue, 14 Jul 2015 14:45:18 +0300 Message-ID: <55A4F64E.3000707@bitdefender.com> References: <1436807687-9826-1-git-send-email-rcojocaru@bitdefender.com> <55A505B10200007800090956@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55A505B10200007800090956@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: jun.nakajima@intel.com, kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, eddie.dong@intel.com, Aravind.Gopalakrishnan@amd.com, suravee.suthikulpanit@amd.com, tlengyel@novetta.com, keir@xen.org, boris.ostrovsky@oracle.com List-Id: xen-devel@lists.xenproject.org On 07/14/2015 01:50 PM, Jan Beulich wrote: >>>> On 13.07.15 at 19:14, wrote: >> I've also moved x86 logic in patch 3/3 to x86 source files, this >> seems to have gone unnoticed but would likely have not compiled >> on ARM. > > Which leaves open whether this time you actually checked that > ARM continues to build. I did check, and again just now. My patches don't break the ARM build, but I just found that on my ARM system, current Xen staging doesn't build: http://pastebin.com/RnywiCX7 # cat /etc/issue Ubuntu 14.04 LTS \n \l # uname -a Linux localhost.localdomain 3.15.0-rc8+ #3 SMP PREEMPT Fri Jan 30 14:08:23 EET 2015 aarch64 aarch64 aarch64 GNU/Linux # gcc -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/lib/gcc/aarch64-linux-gnu/4.9/lto-wrapper Target: aarch64-linux-gnu Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro 4.9.2-10ubuntu13' --with-bugurl=file:///usr/share/doc/gcc-4.9/README.Bugs --enable-languages=c,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-4.9 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.9 --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --enable-gnu-unique-object --disable-libsanitizer --disable-libquadmath --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-4.9-arm64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-4.9-arm64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-4.9-arm64 --with-arch-directory=arm64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-multiarch --disable-werror --enable-checking=release --build=aarch64-linux-gnu --host=aarch64-linux-gnu --target=aarch64-linux-gnu Thread model: posix gcc version 4.9.2 (Ubuntu/Linaro 4.9.2-10ubuntu13) I've temporarily fixed that by wrapping the offending #defines in "#ifndef constant" statements, so that I could continue to check that the build works, but that's likely not the proper fix. Hope this helps, Razvan