From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86/traps: Misc tweaks to several printk()s
Date: Wed, 15 Jul 2015 10:03:43 +0100 [thread overview]
Message-ID: <55A63E0F0200007800091296@mail.emea.novell.com> (raw)
In-Reply-To: <1436896485-25577-1-git-send-email-andrew.cooper3@citrix.com>
>>> On 14.07.15 at 19:54, <andrew.cooper3@citrix.com> wrote:
> @@ -626,8 +626,9 @@ static void do_trap(struct cpu_user_regs *regs, int use_error_code)
>
> if ( likely((fixup = search_exception_table(regs->eip)) != 0) )
> {
> - dprintk(XENLOG_ERR, "Trap %d: %p -> %p\n",
> - trapnr, _p(regs->eip), _p(fixup));
> + printk(XENLOG_INFO "Exception [#%d, ec=%04x] (%s): %ps %p -> %p\n",
> + trapnr, use_error_code ? regs->error_code : 0, trapstr(trapnr),
> + _p(regs->eip), _p(regs->eip), _p(fixup));
But why the transition dprintk() -> printk()?
> @@ -2677,9 +2678,9 @@ static int emulate_privileged_op(struct cpu_user_regs *regs)
>
> if ( (rdmsr_safe(regs->ecx, val) != 0) || (msr_content != val) )
> invalid:
> - gdprintk(XENLOG_WARNING, "Domain attempted WRMSR %p from "
> - "0x%016"PRIx64" to 0x%016"PRIx64".\n",
> - _p(regs->ecx), val, msr_content);
> + gprintk(XENLOG_WARNING,
> + "attempted WRMSR 0x%08x: 0x%016"PRIx64" -> 0x%016"PRIx64"\n",
> + regs->_ecx, val, msr_content);
In cases where the values can't usefully be taken to be decimal I'd
prefer the 0x prefixes to be omitted.
> @@ -2813,10 +2814,11 @@ static int emulate_privileged_op(struct cpu_user_regs *regs)
> case MSR_EFER:
> rdmsr_normal:
> /* Everyone can read the MSR space. */
> - /* gdprintk(XENLOG_WARNING,"Domain attempted RDMSR %p.\n",
> - _p(regs->ecx));*/
> if ( rdmsr_safe(regs->ecx, val) )
> + {
> + gprintk(XENLOG_WARNING, "attempted RDMSR 0x%08x\n", regs->_ecx);
> goto fail;
> + }
Do you really see this to be useful in production builds?
Jan
next prev parent reply other threads:[~2015-07-15 9:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 17:54 [PATCH] x86/traps: Misc tweaks to several printk()s Andrew Cooper
2015-07-15 9:03 ` Jan Beulich [this message]
2015-07-15 9:48 ` Andrew Cooper
2015-07-15 10:01 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A63E0F0200007800091296@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).