From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [v8][PATCH 03/16] xen/passthrough: extend hypercall
 to support rdm reservation policy
Date: Thu, 16 Jul 2015 08:58:02 +0100
Message-ID: <55A7802A0200007800091AFB@mail.emea.novell.com>
References: <1437029582-19564-1-git-send-email-tiejun.chen@intel.com>
	<1437029582-19564-4-git-send-email-tiejun.chen@intel.com>
	<55A77C140200007800091ACB@mail.emea.novell.com>
	<55A761C4.3050203@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55A761C4.3050203@intel.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tiejun Chen <tiejun.chen@intel.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Tim Deegan <tim@xen.org>, xen-devel@lists.xen.org, Stefano Stabellini <stefano.stabellini@citrix.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Yang Zhang <yang.z.zhang@intel.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
List-Id: xen-devel@lists.xenproject.org

>>> On 16.07.15 at 09:48, <tiejun.chen@intel.com> wrote:
> On 2015/7/16 15:40, Jan Beulich wrote:
>>>>> On 16.07.15 at 08:52, <tiejun.chen@intel.com> wrote:
>>> @@ -1577,9 +1578,15 @@ int iommu_do_pci_domctl(
>>>           seg = machine_sbdf >> 16;
>>>           bus = PCI_BUS(machine_sbdf);
>>>           devfn = PCI_DEVFN2(machine_sbdf);
>>> +        flag = domctl->u.assign_device.flag;
>>> +        if ( flag > XEN_DOMCTL_DEV_RDM_RELAXED )
>>
>> Didn't we settle on flag & ~XEN_DOMCTL_DEV_RDM_RELAXED?
> 
> Sorry its my fault to miss this merge.
> 
> BTW, could I resend this patch separately to get your Ack? If you don't 
> have other objections.

Actually if we were to commit (parts of) this version, I'd even be fine
with doing the adjustment upon commit. So I'd suggest making the
change in your local copy so it would be as intended on v9, should
that need sending.

Jan