From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 11/17] xen/arm: ITS: Add GICR register emulation Date: Thu, 16 Jul 2015 16:58:42 +0200 Message-ID: <55A7C6A2.80403@citrix.com> References: <1436514172-3263-1-git-send-email-vijay.kilari@gmail.com> <1436514172-3263-12-git-send-email-vijay.kilari@gmail.com> <55A69925.9070408@citrix.com> <55A7C2AA.8090805@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Vijay Kilari Cc: Ian Campbell , Stefano Stabellini , Prasun Kapoor , Vijaya Kumar K , Tim Deegan , "xen-devel@lists.xen.org" , Stefano Stabellini , manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On 16/07/2015 16:46, Vijay Kilari wrote: >> So you have to handle it properly to avoid the helper reading out of the LPI >> configuration table. > > the check on size lpi_size manages this. I don't see any check on the lpi_size... While the code in this function looks ok, there is some usage of the LPI configuration where you don't check the validity of the offset (I'm thinking of vgic_its_get_priority in patch #12). Regards, -- Julien Grall