From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH] dmar: Fix double free in error paths
 following c/s a8bc99b
Date: Thu, 16 Jul 2015 14:22:06 +0100
Message-ID: <55A7CC1E0200007800091EB0@mail.emea.novell.com>
References: <1437047823-24686-1-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1437047823-24686-1-git-send-email-andrew.cooper3@citrix.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Yang Zhang <yang.z.zhang@intel.com>, Elena Ufimtseva <elena.ufimtseva@oracle.com>, Kevin Tian <kevin.tian@intel.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

>>> On 16.07.15 at 13:57, <andrew.cooper3@citrix.com> wrote:
> Several error paths would end up freeing scope->devices twice.

Of course it depends how you count, but I can spot exactly one
broken case - in acpi_parse_dev_scope(). All other callers of
scope_devices_free() free the container right afterwards afaics.

Jan