From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [v8][PATCH 07/16] hvmloader/e820: construct guest
 e820 table
Date: Thu, 16 Jul 2015 23:42:38 +0800
Message-ID: <55A7D0EE.2030203@intel.com>
References: <1437029582-19564-1-git-send-email-tiejun.chen@intel.com>
	<1437029582-19564-8-git-send-email-tiejun.chen@intel.com>
	<CAFLBxZZVMifw5CTLPQOtqOsWq6YGMjCS6T8BdH7-0280txV3mQ@mail.gmail.com>
	<55A7ADAC.1010004@intel.com>
	<CAFLBxZZdW0dH49j1Lyke5WYpV4P0F9tUVoVD4tJSdxTt95J_Aw@mail.gmail.com>
	<55A7C804.2040101@intel.com> <55A7CABE.4040005@citrix.com>
	<55A7CDBF.1030104@intel.com> <55A7CEBB.8090701@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55A7CEBB.8090701@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Jan Beulich <jbeulich@suse.com>, Wei Liu <wei.liu2@citrix.com>
List-Id: xen-devel@lists.xenproject.org

>> Honestly I didn't try to change that point but maybe I'm missing something?
>
> Yes, you are missing something. :-)  I told you exactly what I wanted
> changed and what I said could remain the same:
>
>>> By all means, calculate high_mem_end so it's easier to read.  But then,
>>> when creating a new region, set e820[nr].size = add_high_mem, so that
>>> the BUG_ON() that follows actually checks something useful.
>
> Just to be clear, I want the second if() statement to look like this:
>
>>>> +        if ( i == nr )
>>>> +        {
>>>> +            e820[nr].addr = ((uint64_t)1 << 32);
>>>> +            e820[nr].size = add_high_mem;

Ahh, when you're replying this, I also see this difference and realize 
what you meant. Sorry to this inconvenience and I'll sync this line into 
my tree :)

Thanks
Tiejun

>>>> +            e820[nr].type = E820_RAM;
>>>> +            nr++;
>>>> +        }
>
> Think about why and maybe that will help you understand what I'm talking
> about.
>
>   -George
>