From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 04/20] xen/grant: Add helper gnttab_page_grant_foreign_access_ref Date: Thu, 16 Jul 2015 17:12:51 +0100 Message-ID: <55A7D803.4070308__25076.0895120495$1437063235$gmane$org@citrix.com> References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com> <1436474552-31789-5-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFlmK-0000v6-SC for xen-devel@lists.xenproject.org; Thu, 16 Jul 2015 16:12:56 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: ian.campbell@citrix.com, Julien Grall , linux-kernel@vger.kernel.org, David Vrabel , xen-devel@lists.xenproject.org, Boris Ostrovsky , linux-arm-kernel@lists.infradead.org List-Id: xen-devel@lists.xenproject.org Hi Stefano, On 16/07/2015 16:05, Stefano Stabellini wrote: > I like this. I think it might make sense to call it > gnttab_page_grant_foreign_access_ref_one to make clear that it is only > granting the first 4K. Will do. > In the future we could introduce a new function, called > gnttab_page_grant_foreign_access_ref, that grants all 4K in the page. Unless having a different prototype it won't be possible to do it. This is because one ref = one grant. We would need a list of grant. > In any case > > Reviewed-by: Stefano Stabellini Thank you, -- Julien Grall