From: Juergen Gross <jgross@suse.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: xen-devel@lists.xensource.com, stefano.stabellini@eu.citrix.com
Subject: Re: [Patch RFC 1/4] usb: support device specification via <bus>-<port>
Date: Fri, 17 Jul 2015 09:32:45 +0200 [thread overview]
Message-ID: <55A8AF9D.6050202@suse.com> (raw)
In-Reply-To: <1437116387.3689.8.camel@redhat.com>
On 07/17/2015 08:59 AM, Gerd Hoffmann wrote:
> On Do, 2015-07-16 at 17:47 +0200, Juergen Gross wrote:
>> Today a host usb device can be specified either via <vendor>:<product>
>> or via <bus>.<device> syntax. Add the possibility to specify it via
>> <bus>-<port> as this is needed for the support of xen pvusb backend.
>
> -device usb-host,hostbus=<bus>,hostport=<port> should already do what
> you want.
The problem is I have to add the device while qemu is already running,
so I'm using usb_host_device_open(). To be able to specify the device
via <bus>-<port> I have to add the capability to find the device by
those parameters.
I haven't found another way to achieve this.
>> diff --git a/hw/usb/host-legacy.c b/hw/usb/host-legacy.c
>> index 3cc9c42..526108c 100644
>> --- a/hw/usb/host-legacy.c
>> +++ b/hw/usb/host-legacy.c
>
> I don't think we should extend this. This exists purely for backward
> compatibility reasons.
>
>> +out:
>> qdev_prop_set_uint32(&dev->qdev, "hostbus", filter.bus_num);
>> qdev_prop_set_uint32(&dev->qdev, "hostaddr", filter.addr);
>> + if (filter.port) {
>> + qdev_prop_set_string(&dev->qdev, "port", filter.port);
>
> Hmm? This should have been "hostport", right?
Hmm, yes.
Juergen
next prev parent reply other threads:[~2015-07-17 7:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 15:47 [Patch RFC 0/4] usb, xen: add pvUSB backend Juergen Gross
2015-07-16 15:47 ` [Patch RFC 1/4] usb: support device specification via <bus>-<port> Juergen Gross
2015-07-17 6:59 ` Gerd Hoffmann
2015-07-17 7:32 ` Juergen Gross [this message]
2015-07-17 8:28 ` Gerd Hoffmann
2015-07-17 10:06 ` Juergen Gross
2015-07-17 10:23 ` Gerd Hoffmann
2015-07-17 10:25 ` Juergen Gross
2015-07-16 15:47 ` [Patch RFC 2/4] usb: add flag to USBPacket to request complete callback after isoc transfer Juergen Gross
2015-07-17 8:12 ` Gerd Hoffmann
2015-07-17 8:44 ` Juergen Gross
2015-07-17 9:23 ` Gerd Hoffmann
2015-07-17 10:14 ` Juergen Gross
2015-07-16 15:47 ` [Patch RFC 3/4] xen: introduce dummy system device Juergen Gross
2015-07-16 15:47 ` [Patch RFC 4/4] xen: add pvUSB backend Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A8AF9D.6050202@suse.com \
--to=jgross@suse.com \
--cc=kraxel@redhat.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).