From: "Jan Beulich" <JBeulich@suse.com>
To: Shuai Ruan <shuai.ruan@intel.com>
Cc: kevin.tian@intel.com, wei.liu2@citrix.com, eddie.dong@intel.com,
stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
jun.nakajima@intel.com, keir@xen.org, Ian.Campbell@citrix.com
Subject: Re: [PATCH 4/6] libxc: expose xsaves/xgetbv1/xsavec to hvm guest
Date: Fri, 17 Jul 2015 08:47:36 +0100 [thread overview]
Message-ID: <55A8CF380200007800092561@mail.emea.novell.com> (raw)
In-Reply-To: <1437118016-25547-5-git-send-email-shuai.ruan@intel.com>
>>> On 17.07.15 at 09:26, <shuai.ruan@intel.com> wrote:
> @@ -247,8 +250,7 @@ static void xc_cpuid_config_xsave(
> regs[1] = 512 + 64; /* FP/SSE + XSAVE.HEADER */
> break;
> case 1: /* leaf 1 */
> - regs[0] &= XSAVEOPT;
> - regs[1] = regs[2] = regs[3] = 0;
This deletion as well as ...
> + regs[0] &= (XSAVEOPT | XSAVEC | XGETBV1 | XSAVES);
> break;
> case 2 ... 63: /* sub-leaves */
> if ( !(xfeature_mask & (1ULL << input[1])) )
> @@ -256,8 +258,6 @@ static void xc_cpuid_config_xsave(
> regs[0] = regs[1] = regs[2] = regs[3] = 0;
> break;
> }
> - /* Don't touch EAX, EBX. Also cleanup ECX and EDX */
> - regs[2] = regs[3] = 0;
... this one need explaining in the description. And in this latter
case the comment should probably be retained/amended if the
code deletion is really intended/warranted.
Jan
next prev parent reply other threads:[~2015-07-17 7:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 7:26 [PATCH v2 0/6] add xsaves/xrstors support Shuai Ruan
2015-07-17 7:26 ` [PATCH 1/6] x86/xsaves: enable xsaves/xrstors for pv guest Shuai Ruan
2015-07-17 16:21 ` Konrad Rzeszutek Wilk
2015-07-21 9:43 ` Ruan, Shuai
2015-07-21 13:12 ` Konrad Rzeszutek Wilk
2015-07-17 7:26 ` [PATCH 2/6] x86/xsaves: enable xsaves/xrstors in xen Shuai Ruan
2015-07-17 7:26 ` [PATCH 3/6] x86/xsaves: enable xsaves/xrstors for hvm guest Shuai Ruan
2015-07-17 7:26 ` [PATCH 4/6] libxc: expose xsaves/xgetbv1/xsavec to " Shuai Ruan
2015-07-17 7:47 ` Jan Beulich [this message]
2015-07-17 8:10 ` Ruan, Shuai
2015-07-17 10:47 ` Jan Beulich
2015-07-21 9:33 ` Ruan, Shuai
2015-07-21 9:47 ` Jan Beulich
2015-07-17 7:26 ` [PATCH 5/6] x86/xsaves: support compact format for hvm save/restore Shuai Ruan
2015-07-17 7:26 ` [PATCH 6/6] x86/xsaves: detect xsaves/xgetbv1 in xen Shuai Ruan
2015-07-17 20:15 ` [PATCH v2 0/6] add xsaves/xrstors support Andrew Cooper
2015-07-21 9:25 ` Ruan, Shuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A8CF380200007800092561@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=Ian.Campbell@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=shuai.ruan@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).