From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>, Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 4/4] tools/libxl: Initialise the fd of the unused half of a datacopier
Date: Fri, 17 Jul 2015 18:11:57 +0100 [thread overview]
Message-ID: <55A9375D.8010801@citrix.com> (raw)
In-Reply-To: <1437153070.22698.36.camel@citrix.com>
On 17/07/15 18:11, Ian Campbell wrote:
> On Fri, 2015-07-17 at 18:01 +0100, Wei Liu wrote:
>> On Fri, Jul 17, 2015 at 05:59:09PM +0100, Andrew Cooper wrote:
>>> This bug causes a spurious failure if stdin happens to be an
>>> appropriately readable/writeable pipe which receives a POLLHUP
>>>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> CC: Ian Campbell <Ian.Campbell@citrix.com>
>>> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
>>> CC: Wei Liu <wei.liu2@citrix.com>
>>>
>> Acked-by: Wei Liu <wei.liu2@citrix.com>
> I've pushed just this one in the hopes of unblocking the testing over
> the weekend (I've got to go soon is the only reason I didn't touch the
> other three).
>
> I had to rebase a little to account for the other patches, hopefully I
> didn't bugger it up!
Ah yes - you would have to.
What is in there looks correct.
~Andrew
next prev parent reply other threads:[~2015-07-17 17:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 16:51 [PATCH 0/4] Fix to libxl migration v2 issue blocking OSSTest Andrew Cooper
2015-07-17 16:51 ` [PATCH 1/4] tools/libxc: Identify the path of the kernel image which cannot be found Andrew Cooper
2015-07-17 16:53 ` Ian Campbell
2015-07-17 16:55 ` Wei Liu
2015-07-17 16:51 ` [PATCH 2/4] tools/libxl: Log the subject fd in datacopier messages Andrew Cooper
2015-07-20 9:54 ` Wei Liu
2015-07-17 16:51 ` [PATCH 3/4] tools/libxl: Identify copywhat in stream v2 datacopiers Andrew Cooper
2015-07-20 9:55 ` Wei Liu
2015-07-17 16:51 ` [PATCH 4/4] tools/libxl: Initialise the fd of the unused half of a datacopier Andrew Cooper
2015-07-17 16:55 ` Ian Campbell
2015-07-17 16:55 ` Wei Liu
2015-07-17 16:56 ` Andrew Cooper
2015-07-17 16:59 ` [PATCH v2 " Andrew Cooper
2015-07-17 17:01 ` Wei Liu
2015-07-17 17:11 ` Ian Campbell
2015-07-17 17:11 ` Andrew Cooper [this message]
2015-07-20 9:56 ` [PATCH 0/4] Fix to libxl migration v2 issue blocking OSSTest Wei Liu
2015-07-20 10:11 ` Andrew Cooper
2015-07-21 12:49 ` Wei Liu
2015-07-21 14:51 ` Ian Campbell
2015-07-21 15:05 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A9375D.8010801@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).