From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [v9][PATCH 07/16] hvmloader/e820: construct guest
 e820 table
Date: Fri, 17 Jul 2015 16:31:35 +0100
Message-ID: <55A93BF702000078000928B0@mail.emea.novell.com>
References: <1437093920-11472-1-git-send-email-tiejun.chen@intel.com>
	<1437093920-11472-8-git-send-email-tiejun.chen@intel.com>
	<55A8CD740200007800092545@mail.emea.novell.com>
	<55A8C65C.1020804@intel.com>
	<55A8FA26020000780009269C@mail.emea.novell.com>
	<55A91DAD.7030900@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55A91DAD.7030900@intel.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tiejun Chen <tiejun.chen@intel.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

>>> On 17.07.15 at 17:22, <tiejun.chen@intel.com> wrote:
> Do you mean I should check low/high mem before we add the hypervisor 
> supplied entries

Yes.

> like this?

Not exactly:

> +    for ( i = nr-1; i > memory_map.nr_map; i-- )

Before you add memory_map.nr_map, you should be able to iterate
from 0 to (not inclusive) nr. At least as far as I recall the original
patch.

Jan