From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 0/4] Fix to libxl migration v2 issue blocking OSSTest Date: Mon, 20 Jul 2015 11:11:28 +0100 Message-ID: <55ACC950.2080806@citrix.com> References: <1437151878-11792-1-git-send-email-andrew.cooper3@citrix.com> <20150720095639.GC12455@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150720095639.GC12455@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Xen-devel List-Id: xen-devel@lists.xenproject.org On 20/07/15 10:56, Wei Liu wrote: > On Fri, Jul 17, 2015 at 05:51:14PM +0100, Andrew Cooper wrote: >> And three improvements to debugging. >> >> Note that there is still a bug in libxl__toolstack_save() which >> valgrind identified, but I do not wish to block this bugfix on that >> >> Andrew Cooper (4): >> tools/libxc: Identify the path of the kernel image which cannot be >> found >> tools/libxl: Log the subject fd in datacopier messages >> tools/libxl: Identify copywhat in stream v2 datacopiers > I think all three patches should wait until next development window > opens unless we have nothing else in our queue (which doesn't seem to be > the case at the moment). You mean delay until 4.7? I disagree. Without these fixes, debugging issues is substantially harder than they need to be. They literally are only adding extra information into existing error messages. ~Andrew