From: Julien Grall <julien.grall@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Ting-Wei Lan <lantw44@gmail.com>,
xen-devel@lists.xen.org
Cc: Yang Zhang <yang.z.zhang@intel.com>,
Kevin Tian <kevin.tian@intel.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] VT-d: add iommu=igfx_off option to workaround graphics issues
Date: Mon, 20 Jul 2015 11:19:10 +0100 [thread overview]
Message-ID: <55ACCB1E.6000903@citrix.com> (raw)
In-Reply-To: <55ACB0E1.6000505@citrix.com>
On 20/07/15 09:27, Andrew Cooper wrote:
> On 19/07/2015 16:53, Julien Grall wrote:
>> Hi,
>>
>> On 17/07/2015 20:05, Ting-Wei Lan wrote:
>>> When using Linux >= 3.19 (commit 47591df) as dom0 on some Intel Ironlake
>>> devices, It is possible to encounter graphics issues that make screen
>>> unreadable or crash the system. It was reported in freedesktop bugzilla:
>>>
>>> https://bugs.freedesktop.org/show_bug.cgi?id=90037
>>>
>>> As we still cannot find a proper fix for this problem, this patch adds
>>> iommu=igfx_off option that is similar to Linux intel_iommu=igfx_off for
>>> users to manually workaround the problem.
>>
>> I would prefer to see the introduction of intel_iommu parameter in the
>> vtd code rather than extending again the iommu parameter with intel
>> specific options in the common code which is both for ARM and x86.
>
> Having the parsing for this option inside some x86 ifdefary, fine, but
> lets not have multiple iommu= options. It is hard enough for people to
> drive one option (as people routinely get Xen and Linux command line
> options mixed up).
If you are concerned about mixing Xen and Linux command line options, it
would be more sensible to use intel_iommu=igfx_off on Xen to keep the
options exactly the same as Linux.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-07-20 10:19 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 19:05 [PATCH] VT-d: add iommu=igfx_off option to workaround graphics issues Ting-Wei Lan
2015-07-17 19:36 ` Andrew Cooper
2015-07-18 8:46 ` 藍挺瑋
2015-07-19 15:53 ` Julien Grall
2015-07-20 8:27 ` Andrew Cooper
2015-07-20 10:19 ` Julien Grall [this message]
2015-07-20 1:28 ` Tian, Kevin
2015-07-20 8:21 ` Andrew Cooper
2015-07-20 10:44 ` Ting-Wei Lan
2015-07-21 0:57 ` Tian, Kevin
2015-07-21 6:56 ` Jan Beulich
2015-07-21 7:05 ` Tian, Kevin
2015-07-21 7:16 ` Jan Beulich
2015-07-21 7:23 ` Tian, Kevin
2015-07-21 7:33 ` Jan Beulich
2015-07-23 16:41 ` Ting-Wei Lan
2015-07-20 8:46 ` Jan Beulich
2015-07-25 16:57 ` [PATCH v2] VT-d: add iommu=igfx " Ting-Wei Lan
2015-07-26 16:47 ` Andrew Cooper
2015-07-31 1:26 ` Tian, Kevin
2015-07-31 8:37 ` Ting-Wei Lan
2015-08-04 2:00 ` Tian, Kevin
2015-08-05 9:11 ` [PATCH v3] " Ting-Wei Lan
2015-08-05 12:18 ` Andrew Cooper
2015-08-05 13:35 ` Wei Liu
2015-08-05 17:10 ` [PATCH v4] " Ting-Wei Lan
2015-08-06 0:49 ` Tian, Kevin
2015-08-06 8:25 ` Wei Liu
2015-08-06 9:28 ` Ian Campbell
2015-07-20 12:12 ` [PATCH] VT-d: add iommu=igfx_off " Andrew Cooper
2015-07-20 12:24 ` Jan Beulich
2015-07-20 12:34 ` Andrew Cooper
2015-07-20 13:55 ` Jan Beulich
2015-07-20 14:12 ` Andrew Cooper
2015-07-20 14:25 ` Jan Beulich
2015-07-21 1:15 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ACCB1E.6000903@citrix.com \
--to=julien.grall@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=lantw44@gmail.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).