From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [v10][PATCH 11/16] tools/libxl: detect and avoid
 conflicts with RDM
Date: Tue, 21 Jul 2015 19:45:24 +0800
Message-ID: <55AE30D4.8000009@intel.com>
References: <1437373023-14884-1-git-send-email-tiejun.chen@intel.com>
	<1437373023-14884-12-git-send-email-tiejun.chen@intel.com>
	<21932.63595.566823.211293@mariner.uk.xensource.com>
	<21934.8684.318670.874156@mariner.uk.xensource.com>
	<55AE272A.4020306@intel.com>
	<21934.10490.615041.203428@mariner.uk.xensource.com>
	<55AE2BB1.9030604@intel.com>
	<21934.11410.844215.554291@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21934.11410.844215.554291@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

> The domain destroy would not change cfg at all.

Okay.

>
>> If not, I should double check this duplication so what about a return in
>> the case of duplicating one entry?
>
> What I am looking for is a *decision* about what the right behaviour
> is, backed up by a *rationale*.
>
> The most obvious answer to me would be that if an rdms array is
> specified, the strategy should be ignored.  That is how the automatic
> numa placement API works.

I'm not familiar with this.

Do you mean this?

     if (d_config->num_rdms)
         strategy = LIBXL_RDM_RESERVE_STRATEGY_IGNORE;

But except this global strategy, we also have per-device setting so 
maybe something like this?

     if (d_config->num_rdms)
         return 0;

>
> But another answer would be to take the union of the specified
> regions.  That would be more complicated, because the union would have
> to be computed.
>
>>               if (d_config->rdms[i].start == rdm_start)
>>                   return;
>
> That doesn't, of course, compute the union.
>

Sorry I don't understand what the "take the union of the specified 
regions" is here.

Thanks
Tiejun