From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 07/20] block/xen-blkfront: split get_grant in 2 Date: Tue, 21 Jul 2015 14:03:28 +0100 Message-ID: <55AE4320.7020000__46011.9127914824$1437484054$gmane$org@citrix.com> References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com> <1436474552-31789-8-git-send-email-julien.grall@citrix.com> <55AE1F2A.6010300@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHXEQ-0002Kr-HE for xen-devel@lists.xenproject.org; Tue, 21 Jul 2015 13:05:14 +0000 In-Reply-To: <55AE1F2A.6010300@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , xen-devel@lists.xenproject.org Cc: ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, linux-kernel@vger.kernel.org, David Vrabel , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org List-Id: xen-devel@lists.xenproject.org SGksCgpPbiAyMS8wNy8xNSAxMTozMCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToKPiBFbCAwOS8w Ny8xNSBhIGxlcyAyMi40MiwgSnVsaWVuIEdyYWxsIGhhIGVzY3JpdDoKPj4gUHJlcGFyZSB0aGUg Y29kZSB0byBzdXBwb3J0IDY0S0IgcGFnZSBncmFudWxhcml0eS4gVGhlIGZpcnN0Cj4+IGltcGxl bWVudGF0aW9uIHdpbGwgdXNlIGEgZnVsbCBMaW51eCBwYWdlIHBlciBpbmRpcmVjdCBhbmQgcGVy c2lzdGVudAo+PiBncmFudC4gV2hlbiBub24tcGVyc2lzdGVudCBncmFudCBpcyB1c2VkLCBlYWNo IHBhZ2Ugb2YgYSBiaW8gcmVxdWVzdAo+PiBtYXkgYmUgc3BsaXQgaW4gbXVsdGlwbGUgZ3JhbnQu Cj4+Cj4+IEZ1cnRoZXJtb3JlLCB0aGUgZmllbGQgcGFnZSBvZiB0aGUgZ3JhbnQgc3RydWN0dXJl IGlzIG9ubHkgdXNlZCB0byBjb3B5Cj4+IGRhdGEgZnJvbSBwZXJzaXN0ZW50IGdyYW50IG9yIGlu ZGlyZWN0IGdyYW50LiBBdm9pZCB0byBzZXQgaXQgZm9yIG90aGVyCj4+IHVzZSBjYXNlIGFzIGl0 IHdpbGwgaGF2ZSBubyBtZWFuaW5nIGdpdmVuIHRoZSBwYWdlIHdpbGwgYmUgc3BsaXQgaW4KPj4g bXVsdGlwbGUgZ3JhbnQuCj4+Cj4+IFByb3ZpZGUgMiBmdW5jdGlvbnMsIHRvIHNldHVwIGluZGly ZWN0IGdyYW50LCB0aGUgb3RoZXIgZm9yIGJpbyBwYWdlLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBK dWxpZW4gR3JhbGwgPGp1bGllbi5ncmFsbEBjaXRyaXguY29tPgo+PiBDYzogS29ucmFkIFJ6ZXN6 dXRlayBXaWxrIDxrb25yYWQud2lsa0BvcmFjbGUuY29tPgo+PiBDYzogUm9nZXIgUGF1IE1vbm7D qSA8cm9nZXIucGF1QGNpdHJpeC5jb20+Cj4+IENjOiBCb3JpcyBPc3Ryb3Zza3kgPGJvcmlzLm9z dHJvdnNreUBvcmFjbGUuY29tPgo+PiBDYzogRGF2aWQgVnJhYmVsIDxkYXZpZC52cmFiZWxAY2l0 cml4LmNvbT4KPj4gLS0tCj4+ICAgICBDaGFuZ2VzIGluIHYyOgo+PiAgICAgICAgIC0gUGF0Y2gg YWRkZWQKPj4gLS0tCj4+ICBkcml2ZXJzL2Jsb2NrL3hlbi1ibGtmcm9udC5jIHwgODUgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2Vk LCA1OSBpbnNlcnRpb25zKCspLCAyNiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvYmxvY2sveGVuLWJsa2Zyb250LmMgYi9kcml2ZXJzL2Jsb2NrL3hlbi1ibGtmcm9udC5j Cj4+IGluZGV4IDdiODFkMjMuLjk1ZmQwNjcgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvYmxvY2sv eGVuLWJsa2Zyb250LmMKPj4gKysrIGIvZHJpdmVycy9ibG9jay94ZW4tYmxrZnJvbnQuYwo+PiBA QCAtMjQyLDM0ICsyNDIsNzcgQEAgb3V0X29mX21lbW9yeToKPj4gIAlyZXR1cm4gLUVOT01FTTsK Pj4gIH0KPj4gIAo+PiAtc3RhdGljIHN0cnVjdCBncmFudCAqZ2V0X2dyYW50KGdyYW50X3JlZl90 ICpncmVmX2hlYWQsCj4+IC0JCQkgICAgICAgc3RydWN0IHBhZ2UgKnBhZ2UsCj4+IC0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGJsa2Zyb250X2luZm8gKmluZm8pCj4+ICtz dGF0aWMgc3RydWN0IGdyYW50ICpnZXRfZnJlZV9ncmFudChzdHJ1Y3QgYmxrZnJvbnRfaW5mbyAq aW5mbykKPj4gIHsKPj4gIAlzdHJ1Y3QgZ3JhbnQgKmdudF9saXN0X2VudHJ5Owo+PiAtCXVuc2ln bmVkIGxvbmcgYnVmZmVyX21mbjsKPj4gIAo+PiAgCUJVR19PTihsaXN0X2VtcHR5KCZpbmZvLT5n cmFudHMpKTsKPj4gIAlnbnRfbGlzdF9lbnRyeSA9IGxpc3RfZmlyc3RfZW50cnkoJmluZm8tPmdy YW50cywgc3RydWN0IGdyYW50LAo+PiAtCSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBub2RlKTsKPj4gKwkJCQkJICBub2RlKTsKPiAKPiBTdHJheSBjaGFuZ2U/CgpObyB0aGUgaW5k ZW50YXRpb24gd2FzIHdyb25nIGJlZm9yZS4KCj4gCj4+ICAJbGlzdF9kZWwoJmdudF9saXN0X2Vu dHJ5LT5ub2RlKTsKPj4gIAo+PiAtCWlmIChnbnRfbGlzdF9lbnRyeS0+Z3JlZiAhPSBHUkFOVF9J TlZBTElEX1JFRikgewo+PiArCWlmIChnbnRfbGlzdF9lbnRyeS0+Z3JlZiAhPSBHUkFOVF9JTlZB TElEX1JFRikKPj4gIAkJaW5mby0+cGVyc2lzdGVudF9nbnRzX2MtLTsKPj4gKwo+PiArCXJldHVy biBnbnRfbGlzdF9lbnRyeTsKPj4gK30KPj4gKwo+PiArc3RhdGljIHZvaWQgZ3JhbnRfZm9yZWln bl9hY2Nlc3MoY29uc3Qgc3RydWN0IGdyYW50ICpnbnRfbGlzdF9lbnRyeSwKPj4gKwkJCQkgY29u c3Qgc3RydWN0IGJsa2Zyb250X2luZm8gKmluZm8pCj4gCj4gR2l2ZW4gdGhhdCB0aGlzIGlzIGp1 c3QgYSB3cmFwcGVyIEkgd291bGQgbWFrZSBpdCBhbiBpbmxpbmUgZnVuY3Rpb24sIG9yCj4gZXZl biBjb25zaWRlciByZW1vdmluZyBpdCBhbmQganVzdCBjYWxsCj4gZ250dGFiX3BhZ2VfZ3JhbnRf Zm9yZWlnbl9hY2Nlc3NfcmVmIGRpcmVjdGx5LgoKSSBwcmVmZXIgdG8ga2VlcCB0aGUgaGVscCBh cyBpdCdzIHVzZWQgaW4gdHdvIHBsYWNlIGFuZCBtYWtlIHRoZSBjYWxsZXIKZnVuY3Rpb24gbW9y ZSByZWFkYWJsZS4KCk1vc3Qgb2YgY29tcGlsZXIgd2lsbCB0cnkgdG8gaW5saW5lIGV2ZW4gd2l0 aG91dCB0aGUgaW5saW5lLiBUaGlzIGlzIHRoZQpjYXNlIG9mIGdjYyB3aGVyZSBib3RoIGdyYW50 X2ZvcmVpZ25fYWNjZXNzIGFuZCBldmVuIGdldF9ncmFudCBhcmUgaW4KZmluZSBpbmxpbmUuIElm IHlvdSByZWFsbHkgd2FudCwgSSBjYW4gYWRkIHRoZSBpbmxpbmUuCgo+PiArewo+PiArCWdudHRh Yl9wYWdlX2dyYW50X2ZvcmVpZ25fYWNjZXNzX3JlZihnbnRfbGlzdF9lbnRyeS0+Z3JlZiwKPj4g KwkJCQkJICAgICBpbmZvLT54YmRldi0+b3RoZXJlbmRfaWQsCj4+ICsJCQkJCSAgICAgZ250X2xp c3RfZW50cnktPnBhZ2UsCj4+ICsJCQkJCSAgICAgMCk7Cj4+ICt9Cj4+ICsKPj4gK3N0YXRpYyBz dHJ1Y3QgZ3JhbnQgKmdldF9ncmFudChncmFudF9yZWZfdCAqZ3JlZl9oZWFkLAo+PiArCQkJICAg ICAgIHVuc2lnbmVkIGxvbmcgbWZuLAo+PiArCQkJICAgICAgIHN0cnVjdCBibGtmcm9udF9pbmZv ICppbmZvKQo+IAo+IEluZGVudGF0aW9uLgoKV2h5PyBUaGUgaW5kZW50YXRpb24gaXMgdmFsaWQs IHRhYnVsYXRpb24gb2YgOCBhcyByZXF1ZXN0ZWQgYnkgdGhlCmNvZGluZyBzdHlsZSwgYW5kIHdp bGwgYmUgYWxpZ25lZCBjb3JyZWN0bHkgaW4geW91ciBlZGl0b3IuIFRoaXMgbWF5IG5vdApiZSB0 aGUgY2FzZSBpbiB5b3VyIG1haWwgcmVhZGVyLgoKPiAKPj4gK3sKPj4gKwlzdHJ1Y3QgZ3JhbnQg KmdudF9saXN0X2VudHJ5ID0gZ2V0X2ZyZWVfZ3JhbnQoaW5mbyk7Cj4+ICsKPj4gKwlpZiAoZ250 X2xpc3RfZW50cnktPmdyZWYgIT0gR1JBTlRfSU5WQUxJRF9SRUYpCj4+ICAJCXJldHVybiBnbnRf bGlzdF9lbnRyeTsKPj4gKwo+PiArCS8qIEFzc2lnbiBhIGdyZWYgdG8gdGhpcyBwYWdlICovCj4+ ICsJZ250X2xpc3RfZW50cnktPmdyZWYgPSBnbnR0YWJfY2xhaW1fZ3JhbnRfcmVmZXJlbmNlKGdy ZWZfaGVhZCk7Cj4+ICsJQlVHX09OKGdudF9saXN0X2VudHJ5LT5ncmVmID09IC1FTk9TUEMpOwo+ PiArCWlmIChpbmZvLT5mZWF0dXJlX3BlcnNpc3RlbnQpCj4+ICsJCWdyYW50X2ZvcmVpZ25fYWNj ZXNzKGdudF9saXN0X2VudHJ5LCBpbmZvKTsKPj4gKwllbHNlIHsKPj4gKwkJLyogR3JhbnQgYWNj ZXNzIHRvIHRoZSBNRk4gcGFzc2VkIGJ5IHRoZSBjYWxsZXIgKi8KPj4gKwkJZ250dGFiX2dyYW50 X2ZvcmVpZ25fYWNjZXNzX3JlZihnbnRfbGlzdF9lbnRyeS0+Z3JlZiwKPj4gKwkJCSAgICAgICAg ICAgICAgICAgICAgICAgIGluZm8tPnhiZGV2LT5vdGhlcmVuZF9pZCwKPj4gKwkJCQkgICAgICAg ICAgICAgICAgbWZuLCAwKTsKPj4gIAl9Cj4+ICAKPj4gKwlyZXR1cm4gZ250X2xpc3RfZW50cnk7 Cj4+ICt9Cj4+ICsKPj4gK3N0YXRpYyBzdHJ1Y3QgZ3JhbnQgKmdldF9pbmRpcmVjdF9ncmFudChn cmFudF9yZWZfdCAqZ3JlZl9oZWFkLAo+PiArCQkJCQlzdHJ1Y3QgYmxrZnJvbnRfaW5mbyAqaW5m bykKPiAKPiBJbmRlbnRhdGlvbi4KCkRpdHRvLgoKUmVnYXJkcywKCi0tIApKdWxpZW4gR3JhbGwK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZl bCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg==