From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl and provide some stable libraries Date: Wed, 22 Jul 2015 13:58:06 +0100 Message-ID: <55AF935E.3080605@citrix.com> References: <1436975173.32371.121.camel@citrix.com> <55A681EC.2050508@citrix.com> <1437563556.12884.32.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1437563556.12884.32.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel Cc: minios-devel@lists.xenproject.org, Ian Jackson , Roger Pau Monne , Wei Liu , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 22/07/15 12:12, Ian Campbell wrote: > >> FWIW, also splitting xl and libxl into different directories. > Yes, good idea (also "eventually ;-)"). > > While I'm accumulating TODO items in this thread, every library which > gets split out needs a careful review before it should be declared > A[PBI] stable. I'm thinking at least: > > * Consistent error handling (return -1 + setting errno=EFOO) > * Correct types > * Const correctness > * General interface sanity check > > Anything else? If we are filling even more copious free time, * Thoughts about documentation in the header files. I think a suitably-configured doxygen ought to suffice for this. (I feel like I am nominating myself to try and get this sorted in a satisfactory fashon.) ~Andrew