From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v4 12/17] xen/arm: ITS: Initialize LPI irq
 descriptors and route
Date: Wed, 22 Jul 2015 14:39:10 +0100
Message-ID: <55AF9CFE.8030408@citrix.com>
References: <1436514172-3263-1-git-send-email-vijay.kilari@gmail.com>
	<1436514172-3263-13-git-send-email-vijay.kilari@gmail.com>
	<1436542215.10074.100.camel@citrix.com>
	<CALicx6t4ou_AHkZHXZMP95SvNrT6YJdN82Xnrp+u2hnbkvcCXg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CALicx6t4ou_AHkZHXZMP95SvNrT6YJdN82Xnrp+u2hnbkvcCXg@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Vijay Kilari <vijay.kilari@gmail.com>, Ian Campbell <ian.campbell@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, Tim Deegan <tim@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

On 22/07/15 14:31, Vijay Kilari wrote:
>>> +    p->desc = desc;
>>
>> This should have happened during routing, not now.
> 
> While routing we don't have vlpi to update p->desc.

Why do you need the p->desc? You don't use at all the p->desc during the
injection because you replaced all the
if ( p->desc ) by if ( p->desc && !is_lpi(p->irq) )

or similar.

regards,

-- 
Julien Grall