From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?windows-1252?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v3 07/32] xen/x86: fix arch_set_info_guest
 for HVM guests
Date: Thu, 23 Jul 2015 12:17:06 +0200
Message-ID: <55B0BF22.7040302@citrix.com>
References: <1435923310-9019-1-git-send-email-roger.pau@citrix.com>
	<1435923310-9019-8-git-send-email-roger.pau@citrix.com>
	<20150710184713.GB30788@l.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=639a7a0fa=roger.pau@citrix.com>)
	id 1ZIDZE-0005bI-3E
	for xen-devel@lists.xenproject.org; Thu, 23 Jul 2015 10:17:32 +0000
In-Reply-To: <20150710184713.GB30788@l.oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
List-Id: xen-devel@lists.xenproject.org

El 10/07/15 a les 20.47, Konrad Rzeszutek Wilk ha escrit:
> On Fri, Jul 03, 2015 at 01:34:45PM +0200, Roger Pau Monne wrote:
>> Add checks for ignored vcpu fields in HVM mode. HVM vCPUs (BSP and APs) are
>> always started in 32bit protected mode with paging disabled.
> 
> This is kind of odd in the placement of the series. The next couple of
> patches deal with the restructure of the HVM guests and the previous
> ones were too.

This patch is placed here because the next patch in this series makes
use of it (see the vcpu_hvm function in "libxc: introduce a xc_dom_arch
for hvm-3.0-x86_32 guests").

> And it is quite salient on the PVH/HVMLite protocol. I would think
> you would want to also update the documentation/misc/pvh as part
> of this patch. Perhaps move this further out in the patch series?

Yes, documentation needs to be updated. I was waiting to have the full
boot protocol nailed down before doing so.

Roger.