From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH v7 10/15] x86/altp2m: add remaining support
	routines.
Date: Thu, 23 Jul 2015 17:08:44 +0100
Message-ID: <55B1118C.80907@citrix.com>
References: <1437606081-6964-1-git-send-email-edmund.h.white@intel.com>
	<1437606081-6964-11-git-send-email-edmund.h.white@intel.com>
	<55B0D896020000780009472B@prv-mh.provo.novell.com>
	<DBC12B0F5509554280826E40BCDEE8BE54FE836C@ORSMSX104.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <DBC12B0F5509554280826E40BCDEE8BE54FE836C@ORSMSX104.amr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Sahita, Ravi" <ravi.sahita@intel.com>, Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>, Wei Liu <wei.liu2@citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, "White,
	Edmund H" <edmund.h.white@intel.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, "Nakajima,
	Jun" <jun.nakajima@intel.com>, "tlengyel@novetta.com" <tlengyel@novetta.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

On 07/23/2015 03:51 PM, Sahita, Ravi wrote:
>>> +int p2m_destroy_altp2m_by_id(struct domain *d, unsigned int idx) {
>>> +    struct p2m_domain *p2m;
>>> +    int rc = -EINVAL;
>>> +
>>> +    if ( !idx || idx > MAX_ALTP2M )
>>
>>     >= (and then also elsewhere further down)?
>>
> 
> Right.

[snip]

> Just wanted to make sure these are also ok to do post 4.6

Well the off-by-one errors certainly need to be fixed for 4.6.

If this was the only thing holding it up, the committer could fix it up
on check-in, or we could take a fix-up patch afterwards.

 -George