From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v7 13/15] x86/altp2m: XSM hooks for altp2m HVM ops Date: Thu, 23 Jul 2015 10:08:56 -0600 Message-ID: <55B12DB90200007800094C70@prv-mh.provo.novell.com> References: <1437606081-6964-1-git-send-email-edmund.h.white@intel.com> <1437606081-6964-14-git-send-email-edmund.h.white@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1437606081-6964-14-git-send-email-edmund.h.white@intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ed White Cc: Tim Deegan , Ravi Sahita , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , xen-devel@lists.xen.org, Jun Nakajima , tlengyel@novetta.com, Daniel De Graaf List-Id: xen-devel@lists.xenproject.org >>> On 23.07.15 at 01:01, wrote: > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -6005,6 +6005,9 @@ static int hvmop_set_param( > nestedhvm_vcpu_destroy(v); > break; > case HVM_PARAM_ALTP2M: > + rc = xsm_hvm_param_altp2mhvm(XSM_PRIV, d); > + if ( rc ) > + break; > if ( a.value > 1 ) > rc = -EINVAL; > if ( a.value && > @@ -6189,6 +6192,9 @@ static int do_altp2m_op( > goto out; > } > > + if ( (rc = xsm_hvm_altp2mhvm_op(XSM_TARGET, d ? d : current->domain)) ) > + goto out; > + Shouldn't this have got updated after the changes to patch 11? Jan