From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH v2 01/20] xen: Add Xen specific page definition Date: Fri, 24 Jul 2015 10:48:09 +0100 Message-ID: <55B209D9.1080602__8121.06848829917$1437731381$gmane$org@citrix.com> References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com> <1436474552-31789-2-git-send-email-julien.grall@citrix.com> <55B20540.3020000@citrix.com> <55B207C6.4020300@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZIZaS-0007Wl-8D for xen-devel@lists.xenproject.org; Fri, 24 Jul 2015 09:48:16 +0000 In-Reply-To: <55B207C6.4020300@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , xen-devel@lists.xenproject.org Cc: linux-kernel@vger.kernel.org, Boris Ostrovsky , ian.campbell@citrix.com, linux-arm-kernel@lists.infradead.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 24/07/15 10:39, Julien Grall wrote: > Hi David, > > On 24/07/15 10:28, David Vrabel wrote: >> On 09/07/15 21:42, Julien Grall wrote: >>> The Xen hypercall interface is always using 4K page granularity on ARM >>> and x86 architecture. >>> >>> With the incoming support of 64K page granularity for ARM64 guest, it >>> won't be possible to re-use the Linux page definition in Xen drivers. >>> >>> Introduce Xen page definition helpers based on the Linux page >>> definition. They have exactly the same name but prefixed with >>> XEN_/xen_ prefix. >>> >>> Also modify page_to_pfn to use new Xen page definition. >>> >>> Signed-off-by: Julien Grall >>> Cc: Konrad Rzeszutek Wilk >>> Cc: Boris Ostrovsky >>> Cc: David Vrabel >>> --- >>> I'm wondering if we should drop page_to_pfn has the macro will likely >>> misuse when Linux is using 64KB page granularity. >> >> I think we want xen_gfn_to_page() and xen_page_to_gfn() and Xen >> front/back drivers never deal with PFNs only GFNs. > > What is xen_gfn_to_page and xen_page_to_gfn? Neither Linux, nor my > series have them. I suggesting that you introduce these. David