From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v4 08/11] x86/intel_pstate: changes in cpufreq_del_cpu for CPU offline Date: Fri, 24 Jul 2015 07:56:09 -0600 Message-ID: <55B260190200007800095392@prv-mh.provo.novell.com> References: <1435231010-22637-1-git-send-email-wei.w.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1435231010-22637-1-git-send-email-wei.w.wang@intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Wang Cc: andrew.cooper3@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org >>> On 25.06.15 at 13:16, wrote: > We change to NULL the cpufreq_cpu_policy pointer after the call of > cpufreq_driver->exit, because the pointer is still needed in > intel_pstate_set_pstate(). Just to continue from where I finished on the previous patch: This is an acceptable change if the goal is for intel_pstate.c to be minimally different from its Linux original. As said in a reply to an earlier version, since it can be done differently (i.e. without doing what you do here), I don't view it as acceptable if the delta of the two files is as big as it is right now. Jan