xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Julien Grall <julien.grall@citrix.com>,
	David Vrabel <david.vrabel@citrix.com>,
	xen-devel@lists.xenproject.org
Cc: linux-mm@kvack.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Daniel Kiper <daniel.kiper@oracle.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 10/10] xen/balloon: pre-allocate p2m entries for ballooned pages
Date: Mon, 27 Jul 2015 10:30:33 +0100	[thread overview]
Message-ID: <55B5FA39.8000401__28379.8316879713$1437989545$gmane$org@citrix.com> (raw)
In-Reply-To: <55B2C882.8050903@citrix.com>

On 25/07/15 00:21, Julien Grall wrote:
> On 24/07/2015 12:47, David Vrabel wrote:
>> @@ -550,6 +551,11 @@ int alloc_xenballooned_pages(int nr_pages, struct
>> page **pages)
>>           page = balloon_retrieve(true);
>>           if (page) {
>>               pages[pgno++] = page;
>> +#ifdef CONFIG_XEN_HAVE_PVMMU
>> +            ret = xen_alloc_p2m_entry(page_to_pfn(page));
> 
> Don't you want to call this function only when the guest is not using
> auto-translated physmap?

xen_alloc_p2m_entry() is a nop in auto-xlate guests, so no need for an
additional check here.

David

  parent reply	other threads:[~2015-07-27  9:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1437738468-24110-1-git-send-email-david.vrabel@citrix.com>
2015-07-24 11:47 ` [PATCHv2 01/10] mm: memory hotplug with an existing resource David Vrabel
2015-07-24 11:47 ` [PATCHv2 02/10] xen/balloon: remove scratch page left overs David Vrabel
2015-07-24 11:47 ` [PATCHv2 03/10] x86/xen: discard RAM regions above the maximum reservation David Vrabel
2015-07-24 11:47 ` [PATCHv2 04/10] xen/balloon: find non-conflicting regions to place hotplugged memory David Vrabel
2015-07-24 11:47 ` [PATCHv2 05/10] xen/balloon: rationalize memory hotplug stats David Vrabel
2015-07-24 11:47 ` [PATCHv2 06/10] xen/balloon: only hotplug additional memory if required David Vrabel
2015-07-24 11:47 ` [PATCHv2 07/10] xen/balloon: make alloc_xenballoon_pages() always allocate low pages David Vrabel
2015-07-24 11:47 ` [PATCHv2 08/10] xen/balloon: use hotplugged pages for foreign mappings etc David Vrabel
2015-07-24 11:47 ` [PATCHv2 09/10] x86/xen: export xen_alloc_p2m_entry() David Vrabel
2015-07-24 11:47 ` [PATCHv2 10/10] xen/balloon: pre-allocate p2m entries for ballooned pages David Vrabel
     [not found] ` <1437738468-24110-10-git-send-email-david.vrabel@citrix.com>
2015-07-24 18:51   ` [PATCHv2 09/10] x86/xen: export xen_alloc_p2m_entry() Konrad Rzeszutek Wilk
2015-07-29 16:10   ` Daniel Kiper
     [not found] ` <1437738468-24110-6-git-send-email-david.vrabel@citrix.com>
2015-07-24 18:54   ` [PATCHv2 05/10] xen/balloon: rationalize memory hotplug stats Konrad Rzeszutek Wilk
2015-07-28 15:22   ` Daniel Kiper
     [not found] ` <1437738468-24110-9-git-send-email-david.vrabel@citrix.com>
2015-07-24 18:55   ` [PATCHv2 08/10] xen/balloon: use hotplugged pages for foreign mappings etc Konrad Rzeszutek Wilk
     [not found]   ` <20150724185545.GD12824@l.oracle.com>
2015-07-27 10:18     ` David Vrabel
     [not found] ` <1437738468-24110-11-git-send-email-david.vrabel@citrix.com>
2015-07-24 23:21   ` [PATCHv2 10/10] xen/balloon: pre-allocate p2m entries for ballooned pages Julien Grall
     [not found]   ` <55B2C882.8050903@citrix.com>
2015-07-27  9:30     ` David Vrabel [this message]
     [not found]     ` <55B5FA39.8000401@citrix.com>
2015-07-27 11:01       ` Julien Grall
     [not found]       ` <55B60F6E.3040901@citrix.com>
2015-07-27 12:40         ` David Vrabel
2015-07-27 19:37 ` [PATCHv2 00/10] mm, xen/balloon: memory hotplug improvements Daniel Kiper
     [not found] ` <1437738468-24110-2-git-send-email-david.vrabel@citrix.com>
2015-07-28 14:54   ` [PATCHv2 01/10] mm: memory hotplug with an existing resource Daniel Kiper
     [not found] ` <1437738468-24110-7-git-send-email-david.vrabel@citrix.com>
2015-07-29 15:55   ` [PATCHv2 06/10] xen/balloon: only hotplug additional memory if required Daniel Kiper
     [not found]   ` <20150729155535.GL3492@olila.local.net-space.pl>
2015-07-29 16:02     ` David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='55B5FA39.8000401__28379.8316879713$1437989545$gmane$org@citrix.com' \
    --to=david.vrabel@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=daniel.kiper@oracle.com \
    --cc=julien.grall@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).