From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v3 32/32] libxl: allow the creation of HVM domains without a device model. Date: Wed, 29 Jul 2015 15:58:48 +0100 Message-ID: <55B8EA28.8070806@citrix.com> References: <1435923310-9019-1-git-send-email-roger.pau@citrix.com> <1435923310-9019-33-git-send-email-roger.pau@citrix.com> <20150728112253.GN5111@zion.uk.xensource.com> <55B8E685.7060109@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKSoo-0005sl-1u for xen-devel@lists.xenproject.org; Wed, 29 Jul 2015 14:58:54 +0000 In-Reply-To: <55B8E685.7060109@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: =?windows-1252?Q?Roger_Pau_Monn=E9?= , Wei Liu Cc: xen-devel@lists.xenproject.org, Ian Jackson , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 29/07/15 15:43, Roger Pau Monn=E9 wrote: >> There is a path that dm_present contains garbage. > Please take into account that I've removed the last break in > LIBXL_DOMAIN_TYPE_HVM, so now the LIBXL_DOMAIN_TYPE_HVM case expands > into the LIBXL_DOMAIN_TYPE_PV case. As a general note, please mark deliberate fallthough cases with a comment, even if it is just /* fallthrough */ This is an aid to Coverity spotting accidental fallthrough. ~Andrew