From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v5 13/22] xen/arm: ITS: Implement gic_is_lpi
 helper function
Date: Thu, 30 Jul 2015 18:14:19 +0100
Message-ID: <55BA5B6B.20907@citrix.com>
References: <1437995524-19772-1-git-send-email-vijay.kilari@gmail.com>
	<1437995524-19772-14-git-send-email-vijay.kilari@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1437995524-19772-14-git-send-email-vijay.kilari@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com, manish.jaggi@caviumnetworks.com, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
List-Id: xen-devel@lists.xenproject.org

Hi Vijay,

On 27/07/15 12:11, vijay.kilari@gmail.com wrote:
> diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
> index a9a5874..f80f291 100644
> --- a/xen/include/asm-arm/gic.h
> +++ b/xen/include/asm-arm/gic.h
> @@ -359,12 +359,14 @@ struct gic_hw_operations {
>      int (*secondary_init)(void);
>      int (*make_hwdom_dt_node)(const struct domain *d,
>                                const struct dt_device_node *node, void *fdt);
> +    bool_t (*is_lpi)(unsigned int irq);

I would much prefer to see a new field nr_lpis in the gic_info structure
and get the check directly in gic_is_lpi.

>  };
>  
>  void register_gic_ops(const struct gic_hw_operations *ops);
>  int gic_make_hwdom_dt_node(const struct domain *d,
>                             const struct dt_device_node *node,
>                             void *fdt);
> +bool_t gic_is_lpi(unsigned int irq);
>  
>  #endif /* __ASSEMBLY__ */
>  #endif
> 

Regards,

-- 
Julien Grall