From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?windows-1252?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v3 07/32] xen/x86: fix arch_set_info_guest
 for HVM guests
Date: Wed, 5 Aug 2015 18:40:14 +0200
Message-ID: <55C23C6E.9010300@citrix.com>
References: <1435923310-9019-1-git-send-email-roger.pau@citrix.com>
	<55A3E0F102000078000903B5@mail.emea.novell.com>
	<55B0C100.6000308@citrix.com>
	<55B0EC520200007800094842@prv-mh.provo.novell.com>
	<1437651718.19412.92.camel@citrix.com> <55B103DD.4030901@citrix.com>
	<55B125440200007800094BD2@prv-mh.provo.novell.com>
	<55B10CDB.5010708@citrix.com> <1437667259.24746.12.camel@citrix.com>
	<55B11316.2000201@citrix.com>
	<55B130420200007800094CB8@prv-mh.provo.novell.com>
	<55B11CBE.8050704@citrix.com> <55B1208C.9090207@citrix.com>
	<55B211D70200007800094FCF@prv-mh.provo.novell.com>
	<55B20C9D.5070708@citrix.com>
	<55B233890200007800095124@prv-mh.provo.novell.com>
	<55B22B5A.8020304@citrix.com>
	<55B24F4A02000078000952CC@prv-mh.provo.novell.com>
	<55B25941.9@citrix.com>
	<55B27AAB02000078000954A0@prv-mh.provo.novell.com>
	<55B26DB1.4020302@citrix.com> <55BF9CE6.1030904@citrix.com>
	<55BFA569.7050102@citrix.com> <55C0FF93.70501@citrix.com>
	<55C1DD1C.3060108@citrix.com> <55C22E1C.5020703@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=652d33fe9=roger.pau@citrix.com>)
	id 1ZN1kF-0006U4-TK
	for xen-devel@lists.xenproject.org; Wed, 05 Aug 2015 16:40:48 +0000
In-Reply-To: <55C22E1C.5020703@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>, David Vrabel <david.vrabel@citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

El 05/08/15 a les 17.39, Andrew Cooper ha escrit:
> On 05/08/15 10:53, Roger Pau Monn=E9 wrote:
>> El 04/08/15 a les 20.08, Andrew Cooper ha escrit:
>>> On 03/08/15 18:31, Roger Pau Monn=E9 wrote:
>>>>     uint32_t cs_base;
>>>>     uint32_t ds_base;
>>>>     uint32_t ss_base;
>>>>     uint32_t cs_limit;
>>>>     uint32_t ds_limit;
>>>>     uint32_t ss_limit;
>>>>     uint16_t cs_ar;
>>>>     uint16_t ds_ar;
>>>>     uint16_t ss_ar;
>>> You need selector entries for each segment as well.
>> Really? What's the point in having the selector if we don't have a GDT,
>> and we allow loading the cached part, which is the relevant one.
> =

> push %cs; push 1f; lret
>
> At all points when segment details are updated, it is the responsibility
> of software to ensure that the details match with the GDT/LDT entry. =

> See for example the Intel and AMD manuals for syscall/sysenter where
> similar "updating segment details behind the scenes" occurs.

I would certainly expect the user to have loaded a proper GDT and
reloaded the segments selectors before attempting to do something like
the above.

I really don't mind adding a cs_sel, ds_sel, ss_sel and tr_sel, I just
think it's quite pointless because it's common practice to load a GDT
and then reload the segment selectors to point to the right entries.

Roger.