From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH] x86/HVM: honor p2m_ram_ro in
 hvm_map_guest_frame_rw()
Date: Fri, 14 Aug 2015 04:38:04 -0600
Message-ID: <55CDE12C020000780009AFAE@prv-mh.provo.novell.com>
References: <55B224660200007800095083@prv-mh.provo.novell.com>
	<55BB9CFC.5010002@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <JBeulich@suse.com>) id 1ZQCNH-00020p-6Y
	for xen-devel@lists.xenproject.org; Fri, 14 Aug 2015 10:38:11 +0000
In-Reply-To: <55BB9CFC.5010002@oracle.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>, suravee.suthikulpanit@amd.com, Andrew Cooper <andrew.cooper3@citrix.com>, Eddie Dong <eddie.dong@intel.com>, Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>, Jun Nakajima <jun.nakajima@intel.com>, xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

>>> On 31.07.15 at 18:06, <boris.ostrovsky@oracle.com> wrote:
> On 07/24/2015 05:41 AM, Jan Beulich wrote:
>> @@ -1693,14 +1703,22 @@ int nvmx_handle_vmclear(struct cpu_user_
>>       else
>>       {
>>           /* Even if this VMCS isn't the current one, we must clear it. */
>> -        vvmcs = hvm_map_guest_frame_rw(gpa >> PAGE_SHIFT, 0);
>> +        bool_t writable;
>> +
>> +        vvmcs = hvm_map_guest_frame_rw(gpa >> PAGE_SHIFT, 0, &writable);
> 
> Since you replaced 'gpa >> PAGE_SHIFT' with 'paddr_to_pfn(gpa' above, 
> perhaps it should be replaced here too.
> 
> Other than that,
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

I took the liberty to downgrade this to an ack (covering SVM) on
v2 (since the SVM part didn't change).

Jan