From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C447C433EF for ; Fri, 15 Oct 2021 10:58:58 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB5BB61056 for ; Fri, 15 Oct 2021 10:58:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CB5BB61056 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.210297.367105 (Exim 4.92) (envelope-from ) id 1mbKvG-0003Qm-8Y; Fri, 15 Oct 2021 10:58:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 210297.367105; Fri, 15 Oct 2021 10:58:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mbKvG-0003Qf-5b; Fri, 15 Oct 2021 10:58:46 +0000 Received: by outflank-mailman (input) for mailman id 210297; Fri, 15 Oct 2021 10:58:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mbKvF-0003QZ-B3 for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 10:58:45 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 4b6ec0d4-ec01-40a2-8227-39e01ab47c73; Fri, 15 Oct 2021 10:58:43 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6329E147A; Fri, 15 Oct 2021 03:58:43 -0700 (PDT) Received: from [10.57.25.205] (unknown [10.57.25.205]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 82AA33F70D; Fri, 15 Oct 2021 03:58:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b6ec0d4-ec01-40a2-8227-39e01ab47c73 Subject: Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages] To: Ian Jackson , Julien Grall Cc: Bertrand Marquis , xen-devel@lists.xenproject.org, Rahul Singh , Wei Liu , Anthony PERARD , Juergen Gross , Stefano Stabellini , Volodymyr Babchuk , Andre Przywara References: <7bdac405-a889-15e1-be19-5876f7253855@xen.org> <24926.53690.621007.507249@mariner.uk.xensource.com> <294BE20A-7E45-405C-BC19-C292295E85E3@arm.com> <24927.7235.736221.270358@mariner.uk.xensource.com> <8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com> <24936.28385.679884.535704@mariner.uk.xensource.com> <6f82141c-8a0b-1e30-a996-223f7c0c508d@xen.org> <24937.20922.73382.850023@mariner.uk.xensource.com> From: Michal Orzel Message-ID: <56490119-6040-9ab1-aab7-e43975cbb80d@arm.com> Date: Fri, 15 Oct 2021 12:58:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <24937.20922.73382.850023@mariner.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 15.10.2021 12:02, Ian Jackson wrote: > Julien Grall writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]"): >> On 14/10/2021 18:54, Ian Jackson wrote: > ... >>> That is, as I understand it on ARM vpci should be enabled if >>> passthrough is enabled and not otherwise. That is precisely what >>> the variable c_info->passthrough is. >> >> On Arm, c_info->passthrough is also set when assigning platform devives >> (e.g. a non-PCI network card). At least for now, we don't want to create >> a node for vCPI in the Device-Tree because we don't enable the >> emulation. So... > > Oh. > >>> 3. Now you can use d_config->c_info.passthrough to gate the addition >>> of the additional stuff to the DT. Ie, that is a respin of this >>> patch 3/3. >> >> ... we will need to check d_config->num_pcidevs for the time being. > > OK. > > Can you leave a comment somewhere (near where c_info.passthrough is > set) pointing to this use of num_pcidevs ? That might save someone > some future confusion. > Here, c_info->passthrough is set to enabled if either d_config->num_pcidevs or d_config->num_dtdevs is set. Do you think we need to add there additional comment? If so can you please help with what should I write there? BTW. None of the patch I'm preparing with regards to this discussion modifies libxl_create where c_info.passthrough i set. Do you still want me to add some comment there? > Thanks, > Ian. > Cheers, Michal