From: Don Slutz <don.slutz@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Jun Nakajima <jun.nakajima@intel.com>, Tim Deegan <tim@xen.org>,
Kevin Tian <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org,
Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Keir Fraser <keir@xen.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v13 5/8] xen: Add vmware_port support
Date: Sun, 20 Dec 2015 13:15:03 -0500 [thread overview]
Message-ID: <5676F027.6030101@Gmail.com> (raw)
In-Reply-To: <56718D6702000078000C04D2@prv-mh.provo.novell.com>
On 12/16/15 10:12, Jan Beulich wrote:
>>>> On 28.11.15 at 22:45, <don.slutz@gmail.com> wrote:
>> ---
>> v13:
>> Changed to uint32_t arch_flags, since the emulation_flags is this.
>
> I don't really understand this sentence, and I also don't understand
> why you couldn't just use another XEN_X86_EMU_ flag, e.g.
> XEN_X86_EMU_VMWARE_PORT (which would be the first one outside
> the current all-or-nothing model).
>
Next attempt at that sentence:
During re-base of the patch, changed uint64_t arch_flags to uint32_t
arch_flags. This appeared to be ok because the added emulation_flags
was a unit32_t.
I have no reason not to use another XEN_X86_EMU_ flag. It was not clear
when I was re-baseing that it would be ok to do so.
Will drop arch_flags and use XEN_X86_EMU_VMWARE_PORT which will not be
added to "all".
-Don Slutz
> Jan
>
next prev parent reply other threads:[~2015-12-20 18:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 21:44 [PATCH v13 0/8] Xen VMware tools support Don Slutz
2015-11-28 21:44 ` [PATCH v13 1/8] tools: Add vga=vmware Don Slutz
2016-01-27 16:55 ` Konrad Rzeszutek Wilk
2015-11-28 21:44 ` [PATCH v13 2/8] xen: Add support for VMware cpuid leaves Don Slutz
2015-12-16 10:28 ` Jan Beulich
2015-12-20 17:48 ` Don Slutz
2015-11-28 21:45 ` [PATCH v13 3/8] tools: Add vmware_hwver support Don Slutz
2015-11-28 21:45 ` [PATCH v13 4/8] vmware: Add VMware provided include file Don Slutz
2015-11-28 21:45 ` [PATCH v13 5/8] xen: Add vmware_port support Don Slutz
2015-12-16 15:12 ` Jan Beulich
2015-12-20 18:15 ` Don Slutz [this message]
2015-11-28 21:45 ` [PATCH v13 6/8] tools: " Don Slutz
2015-11-28 21:45 ` [PATCH v13 7/8] Add IOREQ_TYPE_VMWARE_PORT Don Slutz
2015-12-01 11:28 ` Paul Durrant
2015-12-04 0:23 ` Don Slutz
2015-12-04 8:59 ` Paul Durrant
2015-12-04 21:31 ` Don Slutz
2015-12-07 13:36 ` Paul Durrant
2015-12-14 12:39 ` Don Slutz
2015-12-21 14:10 ` Jan Beulich
2016-01-10 19:42 ` Don Slutz
2016-01-11 13:50 ` Jan Beulich
2015-11-28 21:45 ` [PATCH v13 8/8] Add xentrace to vmware_port Don Slutz
2016-03-04 21:50 ` ping Re: [PATCH v13 0/8] Xen VMware tools support Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5676F027.6030101@Gmail.com \
--to=don.slutz@gmail.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).