From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH v2 07/11] xen/hvmlite: Initialize context
 for secondary VCPUs
Date: Tue, 2 Feb 2016 16:21:26 +0000
Message-ID: <56B0D786.7000002__8248.67783017016$1454430181$gmane$org@citrix.com>
References: <1454341137-14110-1-git-send-email-boris.ostrovsky@oracle.com>
	<1454341137-14110-8-git-send-email-boris.ostrovsky@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=8330d0ca3=david.vrabel@citrix.com>)
	id 1aQdht-0007lq-NO
	for xen-devel@lists.xenproject.org; Tue, 02 Feb 2016 16:21:33 +0000
In-Reply-To: <1454341137-14110-8-git-send-email-boris.ostrovsky@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>, david.vrabel@citrix.com, konrad.wilk@oracle.com
Cc: xen-devel@lists.xenproject.org, mcgrof@suse.com, linux-kernel@vger.kernel.org, roger.pau@citrix.com
List-Id: xen-devel@lists.xenproject.org

This needs some more description in the commit message.

> --- a/arch/x86/xen/smp.c
> +++ b/arch/x86/xen/smp.c
[...]
> +		hctxt->cpu_regs.x86_32.cs_base = 0;
> +		hctxt->cpu_regs.x86_32.cs_limit = ~0u;
> +		hctxt->cpu_regs.x86_32.cs_ar = 0xc9b;
> +		hctxt->cpu_regs.x86_32.ds_base = 0;
> +		hctxt->cpu_regs.x86_32.ds_limit = ~0u;
> +		hctxt->cpu_regs.x86_32.ds_ar = 0xc93;
> +		hctxt->cpu_regs.x86_32.es_base = 0;
> +		hctxt->cpu_regs.x86_32.es_limit = ~0u;
> +		hctxt->cpu_regs.x86_32.es_ar = 0xc93;
> +		hctxt->cpu_regs.x86_32.ss_base = 0;
> +		hctxt->cpu_regs.x86_32.ss_limit = ~0u;
> +		hctxt->cpu_regs.x86_32.ss_ar = 0xc93;
> +		hctxt->cpu_regs.x86_32.tr_base = 0;
> +		hctxt->cpu_regs.x86_32.tr_limit = 0xff;
> +		hctxt->cpu_regs.x86_32.tr_ar = 0x8b;

Lots of hard-coded values here.  Should this be #defined somewhere?

David