From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH v2 09/11] xen/hvmlite: Use x86's default timer init for HVMlite guests Date: Tue, 2 Feb 2016 16:27:09 +0000 Message-ID: <56B0D8DD.5010206__48948.0643104345$1454430518$gmane$org@citrix.com> References: <1454341137-14110-1-git-send-email-boris.ostrovsky@oracle.com> <1454341137-14110-10-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aQdng-00084m-Ok for xen-devel@lists.xenproject.org; Tue, 02 Feb 2016 16:27:32 +0000 In-Reply-To: <1454341137-14110-10-git-send-email-boris.ostrovsky@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky , david.vrabel@citrix.com, konrad.wilk@oracle.com Cc: xen-devel@lists.xenproject.org, mcgrof@suse.com, linux-kernel@vger.kernel.org, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org On 01/02/16 15:38, Boris Ostrovsky wrote: > xen_timer_init() will be called from apic_bsp_setup(). I must be missing something because xen_init_time_ops() is only called from the PV-only xen_start_kernel()? David > --- a/arch/x86/xen/time.c > +++ b/arch/x86/xen/time.c > @@ -492,7 +492,10 @@ void __init xen_init_time_ops(void) > { > pv_time_ops = xen_time_ops; > > - x86_init.timers.timer_init = xen_time_init; > + if (!xen_hvmlite) > + x86_init.timers.timer_init = xen_time_init; > + else > + x86_init.timers.timer_init = x86_init_noop; > x86_init.timers.setup_percpu_clockev = x86_init_noop; > x86_cpuinit.setup_percpu_clockev = x86_init_noop; > >