From: David Vrabel <david.vrabel@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
konrad.wilk@oracle.com
Cc: xen-devel@lists.xenproject.org, mcgrof@suse.com,
linux-kernel@vger.kernel.org, roger.pau@citrix.com
Subject: Re: [PATCH v2 07/11] xen/hvmlite: Initialize context for secondary VCPUs
Date: Thu, 4 Feb 2016 10:07:10 +0000 [thread overview]
Message-ID: <56B322CE.6050701__14137.7045227729$1454580528$gmane$org@citrix.com> (raw)
In-Reply-To: <56B0E046.6050900@oracle.com>
On 02/02/16 16:58, Boris Ostrovsky wrote:
> On 02/02/2016 11:21 AM, David Vrabel wrote:
>> This needs some more description in the commit message.
>>
>>> --- a/arch/x86/xen/smp.c
>>> +++ b/arch/x86/xen/smp.c
>> [...]
>>> + hctxt->cpu_regs.x86_32.cs_base = 0;
>>> + hctxt->cpu_regs.x86_32.cs_limit = ~0u;
>>> + hctxt->cpu_regs.x86_32.cs_ar = 0xc9b;
>>> + hctxt->cpu_regs.x86_32.ds_base = 0;
>>> + hctxt->cpu_regs.x86_32.ds_limit = ~0u;
>>> + hctxt->cpu_regs.x86_32.ds_ar = 0xc93;
>>> + hctxt->cpu_regs.x86_32.es_base = 0;
>>> + hctxt->cpu_regs.x86_32.es_limit = ~0u;
>>> + hctxt->cpu_regs.x86_32.es_ar = 0xc93;
>>> + hctxt->cpu_regs.x86_32.ss_base = 0;
>>> + hctxt->cpu_regs.x86_32.ss_limit = ~0u;
>>> + hctxt->cpu_regs.x86_32.ss_ar = 0xc93;
>>> + hctxt->cpu_regs.x86_32.tr_base = 0;
>>> + hctxt->cpu_regs.x86_32.tr_limit = 0xff;
>>> + hctxt->cpu_regs.x86_32.tr_ar = 0x8b;
>> Lots of hard-coded values here. Should this be #defined somewhere?
>
> We also don't need to set bases to zero since hctxt is kzalloc'd. I'll
> remove that and add a comment.
>
> As for macros --- I couldn't find the bits defined symbolically anywhere
> and since this is the only place this is used the macros would be local
> here.
Ok.
David
next prev parent reply other threads:[~2016-02-04 10:07 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 15:38 [PATCH v2 00/11] HVMlite domU support Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 01/11] xen/hvmlite: Import hvmlite-related Xen public interfaces Boris Ostrovsky
2016-02-02 16:06 ` David Vrabel
2016-02-01 15:38 ` [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest Boris Ostrovsky
2016-02-02 16:39 ` David Vrabel
[not found] ` <56B0DBD6.3060205@citrix.com>
2016-02-02 17:19 ` Boris Ostrovsky
2016-02-03 18:55 ` Luis R. Rodriguez
[not found] ` <20160203185525.GV20964@wotan.suse.de>
2016-02-03 20:11 ` Boris Ostrovsky
2016-02-03 20:52 ` Andrew Cooper
[not found] ` <56B25F0C.2050808@oracle.com>
2016-02-03 23:40 ` Luis R. Rodriguez
[not found] ` <20160203234026.GS20964@wotan.suse.de>
2016-02-04 19:54 ` Boris Ostrovsky
[not found] ` <56B3AC67.7080704@oracle.com>
2016-02-04 20:57 ` Luis R. Rodriguez
[not found] ` <20160204205721.GJ12481@wotan.suse.de>
2016-02-04 22:28 ` Boris Ostrovsky
[not found] ` <56B268A2.5000704@citrix.com>
2016-02-03 23:59 ` Luis R. Rodriguez
[not found] ` <20160203235908.GT20964@wotan.suse.de>
2016-02-04 0:08 ` Luis R. Rodriguez
2016-02-04 0:51 ` Andrew Cooper
[not found] ` <56B2A09A.70404@citrix.com>
2016-02-04 23:10 ` Luis R. Rodriguez
[not found] ` <20160204231031.GM12481@wotan.suse.de>
2016-04-05 22:02 ` Luis R. Rodriguez
2016-04-24 20:23 ` Borislav Petkov
[not found] ` <20160424202314.GA3973@pd.tnic>
2016-04-25 13:21 ` Boris Ostrovsky
[not found] ` <571E19D7.1080301@oracle.com>
2016-04-25 13:47 ` Borislav Petkov
[not found] ` <20160425134749.GB28454@pd.tnic>
2016-04-25 13:54 ` Boris Ostrovsky
[not found] ` <571E219D.2090308@oracle.com>
2016-04-25 14:11 ` Borislav Petkov
[not found] ` <20160425141145.GE28454@pd.tnic>
2016-04-25 14:42 ` Boris Ostrovsky
[not found] ` <571E2CC7.7080907@oracle.com>
2016-04-25 15:22 ` Borislav Petkov
[not found] ` <20160425152209.GH28454@pd.tnic>
2016-04-25 15:48 ` Boris Ostrovsky
2016-04-26 10:53 ` Borislav Petkov
2016-04-25 17:24 ` David Vrabel
2016-02-01 15:38 ` [PATCH v2 03/11] xen/hvmlite: Initialize HVMlite kernel Boris Ostrovsky
2016-02-17 20:08 ` Luis R. Rodriguez
2016-02-01 15:38 ` [PATCH v2 04/11] xen/hvmlite: Allow HVMlite guests delay initializing grant table Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 05/11] xen/hvmlite: HVMlite guests always have PV devices Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 06/11] xen/hvmlite: Prepare cpu_initialize_context() routine for HVMlite SMP Boris Ostrovsky
2016-02-02 16:16 ` David Vrabel
2016-02-01 15:38 ` [PATCH v2 07/11] xen/hvmlite: Initialize context for secondary VCPUs Boris Ostrovsky
2016-02-02 16:21 ` David Vrabel
[not found] ` <56B0D786.7000002@citrix.com>
2016-02-02 16:58 ` Boris Ostrovsky
[not found] ` <56B0E046.6050900@oracle.com>
2016-02-04 10:07 ` David Vrabel [this message]
2016-02-04 12:58 ` Doug Goldstein
[not found] ` <56B34B01.50000@cardoe.com>
2016-02-04 19:08 ` Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 08/11] xen/hvmlite: Extend APIC operations for HVMlite guests Boris Ostrovsky
2016-02-04 10:04 ` David Vrabel
[not found] ` <56B32220.4040505@citrix.com>
2016-02-04 12:14 ` Roger Pau Monné
[not found] ` <56B340B4.3050406@citrix.com>
2016-02-04 14:01 ` Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 09/11] xen/hvmlite: Use x86's default timer init " Boris Ostrovsky
2016-02-02 16:27 ` David Vrabel
[not found] ` <56B0D8DD.5010206@citrix.com>
2016-02-02 17:01 ` Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 10/11] xen/hvmlite: Boot secondary CPUs Boris Ostrovsky
2016-02-04 10:38 ` David Vrabel
[not found] ` <56B32A29.6050406@citrix.com>
2016-02-04 13:51 ` Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 11/11] xen/hvmlite: Enable CPU on-/offlining Boris Ostrovsky
[not found] ` <1454341137-14110-5-git-send-email-boris.ostrovsky@oracle.com>
2016-02-02 16:13 ` [PATCH v2 04/11] xen/hvmlite: Allow HVMlite guests delay initializing grant table David Vrabel
[not found] ` <56B0D596.4050301@citrix.com>
2016-02-02 16:49 ` Boris Ostrovsky
2016-02-03 18:59 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='56B322CE.6050701__14137.7045227729$1454580528$gmane$org@citrix.com' \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).