From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH v2 07/11] xen/hvmlite: Initialize context for secondary VCPUs Date: Thu, 4 Feb 2016 06:58:41 -0600 Message-ID: <56B34B01.50000__332.657682202075$1454590816$gmane$org@cardoe.com> References: <1454341137-14110-1-git-send-email-boris.ostrovsky@oracle.com> <1454341137-14110-8-git-send-email-boris.ostrovsky@oracle.com> <56B0D786.7000002@citrix.com> <56B0E046.6050900@oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3608592922113609878==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aRJUn-0006QQ-Q1 for xen-devel@lists.xenproject.org; Thu, 04 Feb 2016 12:58:50 +0000 Received: by mail-yk0-f194.google.com with SMTP id z13so1732030ykd.3 for ; Thu, 04 Feb 2016 04:58:48 -0800 (PST) In-Reply-To: <56B0E046.6050900@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky , David Vrabel , konrad.wilk@oracle.com Cc: xen-devel@lists.xenproject.org, mcgrof@suse.com, linux-kernel@vger.kernel.org, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============3608592922113609878== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6wOncTpra15Hdqhtihh2NovTh0PnNlv0R" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6wOncTpra15Hdqhtihh2NovTh0PnNlv0R Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2/2/16 10:58 AM, Boris Ostrovsky wrote: > On 02/02/2016 11:21 AM, David Vrabel wrote: >> This needs some more description in the commit message. >> >>> --- a/arch/x86/xen/smp.c >>> +++ b/arch/x86/xen/smp.c >> [...] >>> + hctxt->cpu_regs.x86_32.cs_base =3D 0; >>> + hctxt->cpu_regs.x86_32.cs_limit =3D ~0u; >>> + hctxt->cpu_regs.x86_32.cs_ar =3D 0xc9b; >>> + hctxt->cpu_regs.x86_32.ds_base =3D 0; >>> + hctxt->cpu_regs.x86_32.ds_limit =3D ~0u; >>> + hctxt->cpu_regs.x86_32.ds_ar =3D 0xc93; >>> + hctxt->cpu_regs.x86_32.es_base =3D 0; >>> + hctxt->cpu_regs.x86_32.es_limit =3D ~0u; >>> + hctxt->cpu_regs.x86_32.es_ar =3D 0xc93; >>> + hctxt->cpu_regs.x86_32.ss_base =3D 0; >>> + hctxt->cpu_regs.x86_32.ss_limit =3D ~0u; >>> + hctxt->cpu_regs.x86_32.ss_ar =3D 0xc93; >>> + hctxt->cpu_regs.x86_32.tr_base =3D 0; >>> + hctxt->cpu_regs.x86_32.tr_limit =3D 0xff; >>> + hctxt->cpu_regs.x86_32.tr_ar =3D 0x8b; >> Lots of hard-coded values here. Should this be #defined somewhere? >=20 > We also don't need to set bases to zero since hctxt is kzalloc'd. I'll > remove that and add a comment. >=20 > As for macros --- I couldn't find the bits defined symbolically anywher= e > and since this is the only place this is used the macros would be local= > here. >=20 > -boris >=20 It could be useful to have them defined locally if only to give them some more meaning by having a name rather than 0x8b. Just a thought. --=20 Doug Goldstein --6wOncTpra15Hdqhtihh2NovTh0PnNlv0R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWs0sEXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUjHgP/0RidpuZDfIx0rbkMRBBLaJp kUTnNW3fkd6g4Z2l9z5HQ66ylHamBYs28VZc3T9v/5QHN8A/4qa8zXQfXASVbie6 kDjfhz8cl2AcpBPaZ+7jMtyW0bByXnW/BIJVpcCdpLblYbQupfaQhh3vs0uOCZLl oEH7e10edcABRTkz6TznpgKvwaKwrul1j+hCvqgo+GHmYP+KQZ7eksC94b/hVbOm st+PoGpWingTv3rUV32zYgY8UVqXzL2/YVpEab7z5x7q11oQd7RowAZqP9FJSSGH V8fqGsAbuf2gMDtFuLcPSHBhHC5F33IBypvEW0UZpEIchanpfr/UeK4VCk+8lNto JoNeXkgKcLvHV7S8CBTUJX6nwWsEPXvw6KozAJTCpsVIkLGUV6i25Fq/QmCJXBOe /zW2rEP/GjQxnyv1B2jmPr0fEeVl/5qmSBHgu4Pnq95/K07em76dpNh6EMjk+xXE 6ygsbVyUCBwTBO9tiHzrJBbSma1iITWDTeOXanu9UWkY5Ytvix+5K52HTmq1mg20 cEvi6PGHGGXW3gGXsUvgG3JxMZBR0hgfRv7bcCnxVPV3dxNilDxmmEj6CIsFnFLc YIcF18CZfICDdUtJEK6N4k9+uuFITRpcjetBr8/FEesbOJPy3Vle+t8PUV1oX1nn CbDZw2SaQP1PrgU0oESD =bFCk -----END PGP SIGNATURE----- --6wOncTpra15Hdqhtihh2NovTh0PnNlv0R-- --===============3608592922113609878== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3608592922113609878==--