From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2] xen/mm: Fix page_list_* helpers to evaluate all their arguments
Date: Mon, 07 Mar 2016 09:53:04 -0700 [thread overview]
Message-ID: <56DDC00002000078000DA1C7@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1457362866-21460-1-git-send-email-andrew.cooper3@citrix.com>
>>> On 07.03.16 at 16:01, <andrew.cooper3@citrix.com> wrote:
> +static inline void
> +page_list_del2(struct page_info *page, struct page_list_head *head1,
> + struct page_list_head *head2)
> +{
> + list_del(&page->list);
> +}
The conversion of this in particular causes a build failure on ARM
(which doesn't d->arch.relmem_list, used as the second argument
to the above in page_alloc.c), which required me to remove that
commit again before pushing.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-07 16:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-05 16:52 [PATCH] xen/mm: Fix page_list_* helpers to evaluate all their arguments Andrew Cooper
2016-03-05 23:42 ` Doug Goldstein
2016-03-07 13:15 ` Jan Beulich
2016-03-07 15:01 ` [PATCH v2] " Andrew Cooper
2016-03-07 16:53 ` Jan Beulich [this message]
2016-03-07 18:12 ` [PATCH v3] " Andrew Cooper
2016-03-08 9:57 ` Jan Beulich
2016-03-08 11:05 ` Andrew Cooper
2016-03-08 11:25 ` Jan Beulich
2016-03-09 12:12 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DDC00002000078000DA1C7@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).