From: "Jan Beulich" <JBeulich@suse.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>, xen-devel@lists.xen.org
Subject: Re: [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig
Date: Tue, 08 Mar 2016 02:46:30 -0700 [thread overview]
Message-ID: <56DEAD8602000078000DA45D@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1457376161-24982-2-git-send-email-cardoe@cardoe.com>
>>> On 07.03.16 at 19:42, <cardoe@cardoe.com> wrote:
> Have Kconfig set CONFIG_FLASK_AVC_STATS and prefix all uses with CONFIG_
> to use the Kconfig variable.
Same question here: What's the benefit of doing it this way?
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -23,6 +23,12 @@ config FLASK
>
> If unsure, say N.
>
> +config FLASK_AVC_STATS
> + def_bool y if FLASK
> + depends on FLASK
With this "depends" the "if FLASK" is pointless.
Also (again) - indentation.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-08 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 18:42 [PATCH 1/2] xsm: move the XSM_MAGIC value to Kconfig Doug Goldstein
2016-03-07 18:42 ` [PATCH 2/2] xsm: move FLASK_AVC_STATS " Doug Goldstein
2016-03-08 9:46 ` Jan Beulich [this message]
2016-03-08 16:22 ` Daniel De Graaf
2016-03-08 16:51 ` Jan Beulich
2016-03-08 18:01 ` Daniel De Graaf
2016-03-14 14:05 ` Doug Goldstein
2016-03-16 16:09 ` Doug Goldstein
2016-03-08 9:44 ` [PATCH 1/2] xsm: move the XSM_MAGIC value " Jan Beulich
2016-03-08 16:22 ` Daniel De Graaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DEAD8602000078000DA45D@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=cardoe@cardoe.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).