From: Joao Martins <joao.m.martins@oracle.com>
To: Jim Fehlig <jfehlig@suse.com>, libvir-list@redhat.com
Cc: xen-devel@lists.xen.org
Subject: Re: [libvirt] [PATCH V2 3/4] Xen drivers: show hap enabled by default in capabilities
Date: Tue, 8 Mar 2016 16:37:26 +0000 [thread overview]
Message-ID: <56DEFFC6.20503__13651.0289427408$1457455212$gmane$org@oracle.com> (raw)
In-Reply-To: <1456804848-13127-4-git-send-email-jfehlig@suse.com>
On 03/01/2016 04:00 AM, Jim Fehlig wrote:
> Hardware Assisted Paging is enabled by default in Xen. Change
> the capabilities output to reflect this.
>
> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
> ---
> src/libxl/libxl_conf.c | 2 +-
> src/xen/xen_hypervisor.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
> index 93c943b..6efd9b5 100644
> --- a/src/libxl/libxl_conf.c
> +++ b/src/libxl/libxl_conf.c
> @@ -493,7 +493,7 @@ libxlCapsInitGuests(libxl_ctx *ctx, virCapsPtr caps)
>
> if (virCapabilitiesAddGuestFeature(guest,
> "hap",
> - 0,
> + 1,
> 1) == NULL)
> return -1;
> }
> diff --git a/src/xen/xen_hypervisor.c b/src/xen/xen_hypervisor.c
> index c1834cb..fc9e1c6 100644
> --- a/src/xen/xen_hypervisor.c
> +++ b/src/xen/xen_hypervisor.c
> @@ -2206,7 +2206,7 @@ xenHypervisorBuildCapabilities(virConnectPtr conn, virArch hostarch,
> if ((hv_major == 3 && hv_minor >= 3) || (hv_major > 3))
> if (virCapabilitiesAddGuestFeature(guest,
> "hap",
> - false,
> + true,
> true) == NULL)
> goto no_memory;
>
>
For the libxl part,
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-08 16:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 4:00 [PATCH V2 0/4] Extend <hap> to a tristate Jim Fehlig
2016-03-01 4:00 ` [PATCH V2 1/4] conf: add 'state' attribute to <hap> feature Jim Fehlig
2016-03-08 16:37 ` [libvirt] " Joao Martins
2016-03-08 20:21 ` Jim Fehlig
2016-03-01 4:00 ` [PATCH V2 2/4] xenconfig: change 'hap' setting to align with Xen behavior Jim Fehlig
2016-03-08 16:37 ` [libvirt] " Joao Martins
2016-03-01 4:00 ` [PATCH V2 3/4] Xen drivers: show hap enabled by default in capabilities Jim Fehlig
2016-03-08 16:37 ` Joao Martins [this message]
2016-03-01 4:00 ` [PATCH V2 4/4] libxl: support enabling and disabling <hap> feature Jim Fehlig
2016-03-08 16:37 ` [libvirt] " Joao Martins
2016-03-08 4:02 ` [libvirt] [PATCH V2 0/4] Extend <hap> to a tristate Jim Fehlig
[not found] ` <56DE4ED8.4060905@suse.com>
2016-03-16 21:06 ` Jim Fehlig
2016-03-21 12:49 ` Ján Tomko
2016-03-21 15:45 ` Jim Fehlig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='56DEFFC6.20503__13651.0289427408$1457455212$gmane$org@oracle.com' \
--to=joao.m.martins@oracle.com \
--cc=jfehlig@suse.com \
--cc=libvir-list@redhat.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).