From: Andrei Borzenkov <arvidjaar@gmail.com>
To: Fu Wei <fu.wei@linaro.org>
Cc: The development of GNU GRUB <grub-devel@gnu.org>,
xen-devel@lists.xensource.com,
Ian Campbell <Ian.Campbell@citrix.com>,
Vladimir Serbinenko <phcoder@gmail.com>,
Julien Grall <julien.grall@linaro.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
Linaro UEFI Mailman List <linaro-uefi@lists.linaro.org>,
Jon Masters <jcm@redhat.com>
Subject: Re: [PATCH v3 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi
Date: Tue, 8 Mar 2016 20:09:34 +0300 [thread overview]
Message-ID: <56DF074E.1020803@gmail.com> (raw)
In-Reply-To: <CADyBb7uK9aGuBDCvG_Yv9BJwTx9uvbzxajkv-Hy8BibR3W=J+A@mail.gmail.com>
08.03.2016 19:37, Fu Wei пишет:
> Hi Andrei,
>
> On 8 March 2016 at 14:54, Andrei Borzenkov <arvidjaar@gmail.com> wrote:
>> 07.03.2016 11:22, Fu Wei пишет:
>>> Hi Andrei,
>>>
>>> On 28 February 2016 at 00:44, Fu Wei <fu.wei@linaro.org> wrote:
>>>> Hi Andrei
>>>>
>>>> On 28 February 2016 at 01:26, Andrei Borzenkov <arvidjaar@gmail.com> wrote:
>>>>> 26.02.2016 14:13, fu.wei@linaro.org пишет:
>>>>>> From: Fu Wei <fu.wei@linaro.org>
>>>>>>
>>>>>> delete: xen_linux, xen_initrd, xen_xsm
>>>>>> add: xen_module
>>>>>>
>>>>>> This update bases on
>>>>>> commit 0edd750e50698854068358ea53528100a9192902
>>>>>> Author: Vladimir Serbinenko <phcoder@gmail.com>
>>>>>> Date: Fri Jan 22 10:18:47 2016 +0100
>>>>>>
>>>>>> xen_boot: Remove obsolete module type distinctions.
>>>>>>
>>>>>> Signed-off-by: Fu Wei <fu.wei@linaro.org>
>>>>>> ---
>>>>>> docs/grub.texi | 33 ++++++++++-----------------------
>>>>>> 1 file changed, 10 insertions(+), 23 deletions(-)
>>>>>>
>>>>>> diff --git a/docs/grub.texi b/docs/grub.texi
>>>>>> index 82f6fa4..3fbdd99 100644
>>>>>> --- a/docs/grub.texi
>>>>>> +++ b/docs/grub.texi
>>>>>> @@ -3861,9 +3861,7 @@ you forget a command, you can run the command @command{help}
>>>>>> * videoinfo:: List available video modes
>>>>>> @comment * xen_*:: Xen boot commands
>>>>>> * xen_hypervisor:: Load xen hypervisor binary
>>>>>> -* xen_linux:: Load dom0 kernel for xen hypervisor
>>>>>> -* xen_initrd:: Load dom0 initrd for dom0 kernel
>>>>>> -* xen_xsm:: Load xen security module for xen hypervisor
>>>>>> +* xen_module:: Load xen modules for xen hypervisor
>>>>>> @end menu
>>>>>>
>>>>>>
>>>>>> @@ -5141,30 +5139,19 @@ verbatim as the @dfn{kernel command-line}. Any other binaries must be
>>>>>> reloaded after using this command.
>>>>>> @end deffn
>>>>>>
>>>>>> -@node xen_linux
>>>>>> -@subsection xen_linux
>>>>>> +@node xen_module
>>>>>> +@subsection xen_module
>>>>>>
>>>>>> -@deffn Command xen_linux file [arguments]
>>>>>> -Load a dom0 kernel image for xen hypervisor at the booting process of xen.
>>>>>> +@deffn Command xen_module [--nounzip] file [arguments]
>>>>>> +Load a module for xen hypervisor at the booting process of xen.
>>>>>> The rest of the line is passed verbatim as the module command line.
>>>>>
>>>>> ==
>>>>>> +On i386, the modules will be identified by Multiboot(2) protocol.
>>>>>> +On arm64, each module will be identified by the order in which the
>>>>>> +modules are added.
>>>>>
>>>>> I think it is better to skip it entirely. It is not really correct -
>>>>> neither multiboot protocol provides any module identification (Xen
>>>>> probes module types), nor is i386 using multiboot2, nor can all modules
>>>>> be probed, so order still matters. To avoid confusion I'd simply
>>>>> replaced the above three lines with
>>>>>
>>>>> Modules should be loaded in the following order:
>>>>>
>>>>>> +The 1st module: dom0 kernel image
>>>>>> +The 2nd module: dom0 ramdisk (optional)
>>>>>
>>>>> This covers both supported platforms without going into too deep
>>>>> details; if you and Vladimir are OK, I'll commit with this change.
>>>>
>>>> Thank you very much!
>>>> Sorry I am not familiar with xen on i386, so maybe I misunderstand this.
>>>> So please commit with your change, Thanks for your correction :-)
>>>
>>> I just fetched the mainline GRUB, i would like to know why this
>>> patchset haven't been applied?
>>> Anything I need to do(improve it or post a new patchset according to
>>> your suggestion) for this patchset?
>>>
>>
>> Sorry for delay. It is not really about your patchset, but we need some
>> decision about loading additional modules/lack of initrd on ARM. Until
>> then I'd rather avoid committing to any high-level configuration support
>> that will require even more backward compatible hacks later.
>>
>> As it stands now either Xen needs to support autodetection or we need to
>> revert to providing module type explicitly.
>
> So speaking of loading additional modules/lack of initrd on ARM, I thinks that
> will (only) affect loading XSM.
> For this, I have discussed of that with Julien, I think :
> (1) the first module must be kernel
> (2) the second module must be initrd, if we have initrd
> (3) Start from the 2nd module, XEN will detect that if the module is a XSM by
> the XSM binary signature. if we get XSM as the second module, that
> means we have not initrd.
>
If that's the plan, excellent. Vladimir, is it OK to commit then?
> please correct me if I misunderstand it
>
> :-)
>
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
next prev parent reply other threads:[~2016-03-08 17:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 11:13 [PATCH v3 0/4] arm64,xen: add xen_boot support into grup-mkconfig fu.wei
2016-02-26 11:13 ` [PATCH v3 1/4] i386, xen: Add xen_hypervisor and xen_module aliases for i386 fu.wei
2016-02-26 11:13 ` [PATCH v3 2/4] arm64: add "--nounzip" option support in xen_module command fu.wei
2016-02-26 11:13 ` [PATCH v3 3/4] * util/grub.d/20_linux_xen.in: Add xen_boot command support fu.wei
2016-02-26 11:13 ` [PATCH v3 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi fu.wei
2016-02-27 17:26 ` Andrei Borzenkov
2016-02-27 17:44 ` Fu Wei
2016-03-07 8:22 ` Fu Wei
2016-03-08 7:54 ` Andrei Borzenkov
2016-03-08 16:37 ` Fu Wei
2016-03-08 17:09 ` Andrei Borzenkov [this message]
2016-03-09 8:10 ` Julien Grall
2016-03-09 8:22 ` [Xen-devel] " Fu Wei
2016-03-18 7:53 ` Fu Wei
2016-04-13 9:56 ` Fu Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DF074E.1020803@gmail.com \
--to=arvidjaar@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=fu.wei@linaro.org \
--cc=grub-devel@gnu.org \
--cc=jcm@redhat.com \
--cc=julien.grall@linaro.org \
--cc=leif.lindholm@linaro.org \
--cc=linaro-uefi@lists.linaro.org \
--cc=phcoder@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).