From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: [PATCH] x86/xstate: undo bogus adjustment to xsave() Date: Thu, 10 Mar 2016 00:39:16 -0700 Message-ID: <56E132B402000078000DB110@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__Part4F78F5B4.1__=" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1advBo-000857-EV for xen-devel@lists.xenproject.org; Thu, 10 Mar 2016 07:39:20 +0000 List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: xen-devel Cc: Andrew Cooper , Keir Fraser List-Id: xen-devel@lists.xenproject.org This is a MIME message. If you are reading this text, you may want to consider changing to a mail reader or gateway that understands how to properly handle MIME multipart messages. --=__Part4F78F5B4.1__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline This reverts an unintended change in commit 879b44b041 ("x86/fpu: add a per-domain field to set the width of FIP/FDP"), which I had done intermediately while fixing the build issue: After having reverted that adjustment I must have forgotten to "git add" the adjustment. Signed-off-by: Jan Beulich --- a/xen/arch/x86/xstate.c +++ b/xen/arch/x86/xstate.c @@ -292,7 +292,7 @@ void xsave(struct vcpu *v, uint64_t mask) =20 XSAVE("0x48,"); =20 - if ( !(ptr->xsave_hdr.xstate_bv & XSTATE_FP) || + if ( !(mask & ptr->xsave_hdr.xstate_bv & XSTATE_FP) || /* * AMD CPUs don't save/restore FDP/FIP/FOP unless an = exception * is pending. --=__Part4F78F5B4.1__= Content-Type: text/plain; name="x86-XSAVE-FIP-FDP-consider-mask.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="x86-XSAVE-FIP-FDP-consider-mask.patch" x86/xstate: undo bogus adjustment to xsave()=0A=0AThis reverts an = unintended change in commit 879b44b041 ("x86/fpu: add=0Aa per-domain field = to set the width of FIP/FDP"), which I had done=0Aintermediately while = fixing the build issue: After having reverted that=0Aadjustment I must = have forgotten to "git add" the adjustment.=0A=0ASigned-off-by: Jan = Beulich =0A=0A--- a/xen/arch/x86/xstate.c=0A+++ = b/xen/arch/x86/xstate.c=0A@@ -292,7 +292,7 @@ void xsave(struct vcpu *v, = uint64_t mask)=0A =0A XSAVE("0x48,");=0A =0A- if ( = !(ptr->xsave_hdr.xstate_bv & XSTATE_FP) ||=0A+ if ( !(mask & = ptr->xsave_hdr.xstate_bv & XSTATE_FP) ||=0A /*=0A = * AMD CPUs don't save/restore FDP/FIP/FOP unless an exception=0A = * is pending.=0A --=__Part4F78F5B4.1__= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --=__Part4F78F5B4.1__=--