From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Julien Grall <julien.grall@arm.com>,
StefanoStabellini <stefano.stabellini@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 1/2] tools/foreign: Avoid using alignment directives when not appropriate
Date: Thu, 10 Mar 2016 01:33:16 -0700 [thread overview]
Message-ID: <56E13F5C02000078000DB192@prv-mh.provo.novell.com> (raw)
In-Reply-To: <20160309195635.GE31271@citrix.com>
>>> On 09.03.16 at 20:56, <wei.liu2@citrix.com> wrote:
> On Wed, Mar 09, 2016 at 07:03:15PM +0000, Andrew Cooper wrote:
>> The foreign header generation blindly replaces 'uint64_t' with '__align8__
>> uint64_t', to get correct alignment when built as 32bit. This is correct in
>> most circumstances, but Clang objects to two specific uses.
>>
>> * Inside a sizeof() expression
>> * As part of a typecast
>>
>> An example error looks like:
>>
>> /local/xen.git/tools/libxc/../../tools/include/xen/foreign/x86_64.h:204:44:
>> error: 'aligned' attribute ignored when parsing type
> [-Werror,-Wignored-attributes]
>> __align8__ uint64_t evtchn_mask[sizeof(__align8__ uint64_t) * 8];
>> ^~~~~~~~~~
>> /local/xen.git/tools/libxc/../../tools/include/xen/foreign/x86_64.h:13:36:
>> note: expanded from macro '__align8__'
>> ^~~~~~~~~~~
>>
>> This sedary is sufficient to fix all the bad examples without touching any
> of
>> the legitimate uses, and is more simple than teaching mkheader.py how to
> parse
>> C.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Should I apply this and the 2nd patch, or can/should this wait
for Ian to be back?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-10 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 19:03 [PATCH v2 1/2] tools/foreign: Avoid using alignment directives when not appropriate Andrew Cooper
2016-03-09 19:03 ` [PATCH v2 2/2] tools/misc: Drop unused function from gtracestat Andrew Cooper
2016-03-09 19:56 ` Wei Liu
2016-03-09 19:56 ` [PATCH v2 1/2] tools/foreign: Avoid using alignment directives when not appropriate Wei Liu
2016-03-10 8:33 ` Jan Beulich [this message]
2016-03-10 10:52 ` Wei Liu
2016-03-10 8:31 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E13F5C02000078000DB192@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=stefano.stabellini@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).