From: "Jan Beulich" <JBeulich@suse.com>
To: vikrams@codeaurora.org
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com,
shankerd@codeaurora.org
Subject: Re: arm: Missing memset in setup_frametable_mappings
Date: Thu, 10 Mar 2016 01:51:53 -0700 [thread overview]
Message-ID: <56E143B902000078000DB1D3@prv-mh.provo.novell.com> (raw)
In-Reply-To: <136debf45304997fb7ff87bd0a1a10be.squirrel@codeaurora.org>
>>> On 10.03.16 at 01:08, <vikrams@codeaurora.org> wrote:
> I believe there is a bug in setup_frametable_mappings() where the function
> allocates pages for pagetables via alloc_boot_pages() but does not zero them
> out. This results in a crash on Qualcomm systems when prefetching is enabled
> since the processor is free to prefetch a location for which it finds a
> 'valid'
> translation in the page tables, but actually holds uninitialized memory.
>
> A memset to 0 of the variable 'second' for the nr_second pages that were
> allocated fixes the problem.
>
> I didn't see a fix in master branch but may have missed a bug report on the
> mailing list.
Why don't you submit your patch then? That said, I'm getting the
impression that all three uses of alloc_boot_pages() in arm/mm.c
have this problem, not just the one you mention.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-03-10 8:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 0:08 arm: Missing memset in setup_frametable_mappings vikrams
2016-03-10 8:51 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E143B902000078000DB1D3@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=shankerd@codeaurora.org \
--cc=stefano.stabellini@citrix.com \
--cc=vikrams@codeaurora.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).