From: "Jan Beulich" <JBeulich@suse.com>
To: Shanker Donthineni <shankerd@codeaurora.org>
Cc: Julien Grall <julien.grall@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Philip Elcan <pelcan@codeaurora.org>,
Vikram Sethi <vikrams@codeaurora.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] xen: arm: zero EL2 pagetable pages before use
Date: Fri, 11 Mar 2016 04:29:02 -0700 [thread overview]
Message-ID: <56E2BA0E02000078000DB908@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1457647206-9436-1-git-send-email-shankerd@codeaurora.org>
>>> On 10.03.16 at 23:00, <shankerd@codeaurora.org> wrote:
First of all - please correctly Cc maintainers (there were two recent
changes for ARM).
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -730,6 +730,7 @@ void __init setup_xenheap_mappings(unsigned long base_mfn,
> else
> {
> unsigned long first_mfn = alloc_boot_pages(1, 1);
> + memset(mfn_to_virt(first_mfn), 0, PAGE_SIZE);
If I was maintainer of this code, I would demand use of clear_page()
and ask for insertion of the missing blank line here (separating
declaration and statements).
> @@ -771,6 +772,7 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe)
> nr_second = frametable_size >> SECOND_SHIFT;
> second_base = alloc_boot_pages(nr_second, 1);
> second = mfn_to_virt(second_base);
> + memset(second, 0, nr_second * PAGE_SIZE);
> for ( i = 0; i < nr_second; i++ )
> {
> pte = mfn_to_xen_entry(second_base + i, WRITEALLOC);
Along those lines here - use clear_page(), presumably by moving it
into the loop.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-11 11:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 22:00 [PATCH] xen: arm: zero EL2 pagetable pages before use Shanker Donthineni
2016-03-11 11:29 ` Jan Beulich [this message]
2016-03-11 12:56 ` Andrew Cooper
2016-03-11 13:13 ` Jan Beulich
2016-03-11 13:24 ` Andrew Cooper
2016-03-12 16:03 ` Julien Grall
2016-03-14 17:18 ` Shanker Donthineni
2016-03-15 17:37 ` Julien Grall
2016-03-12 14:32 ` Julien Grall
2016-03-14 7:37 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E2BA0E02000078000DB908@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=julien.grall@citrix.com \
--cc=pelcan@codeaurora.org \
--cc=shankerd@codeaurora.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=vikrams@codeaurora.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).