From: "Jan Beulich" <JBeulich@suse.com>
To: Ross Lagerwall <ross.lagerwall@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Kevin Tian <kevin.tian@intel.com>,
Jun Nakajima <jun.nakajima@intel.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2] vmx: Restore debug registers when injecting #DB traps
Date: Mon, 14 Mar 2016 02:57:31 -0600 [thread overview]
Message-ID: <56E68B0B02000078000DBF06@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1457713413-2157-1-git-send-email-ross.lagerwall@citrix.com>
>>> On 11.03.16 at 17:23, <ross.lagerwall@citrix.com> wrote:
> Commit a929bee0e652 ("x86/vmx: Fix injection of #DB traps following
> XSA-156") prevents an infinite loop in certain #DB traps. However, it
> changed the behavior to not call hvm_hw_inject_trap() for #DB and #AC
> traps which which means that the debug registers are not restored
> correctly and nullified commit b56ae5b48c38 ("VMX: fix/adjust trap
> injection").
>
> To fix this, restore the original code path through hvm_inject_trap(),
> but ensure that the struct hvm_trap is populated with all the required
> data.
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-14 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 16:23 [PATCH v2] vmx: Restore debug registers when injecting #DB traps Ross Lagerwall
2016-03-14 8:57 ` Jan Beulich [this message]
2016-03-15 4:37 ` Tian, Kevin
2016-03-16 14:07 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E68B0B02000078000DBF06@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=ross.lagerwall@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).