xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Julien Grall <julien.grall@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 4/5] tmem: don't assume stdbool.h is included
Date: Tue, 15 Mar 2016 02:23:55 -0600	[thread overview]
Message-ID: <56E7D4AB02000078000DC5D9@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1457987365-866-5-git-send-email-cardoe@cardoe.com>

>>> On 14.03.16 at 21:29, <cardoe@cardoe.com> wrote:
> tmem_xen.h assumes that all users will have already included stdbool.h
> which might not always be true.

Wait, no - stdbool.h is not supposed to be included in code other
than such shared with the tool stack. I see ARM has gained some
of those (Julien, Stefano?), but adding more is not acceptable.
I.e. the adjustment, if any is needed (as I can't right away see
how things would build if there really was such a dependency,
and indeed neither .tmem.o.d nor .tmem_xen.o.d list any
stdbool.h as dependencies), would be to replace uses of bool,
true, and false (of which I can't find any in that header) by their
canonical hypervisor variants.


Xen-devel mailing list

  reply	other threads:[~2016-03-15  8:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14 20:29 [PATCH 0/5] Allow tmem to be disabled via Kconfig Doug Goldstein
2016-03-14 20:29 ` [PATCH 1/5] tmem: add tmem_disable() function Doug Goldstein
2016-03-15  8:12   ` Jan Beulich
2016-03-14 20:29 ` [PATCH 2/5] tmem: drop direct usage of opt_tmem Doug Goldstein
2016-03-15  8:15   ` Jan Beulich
2016-03-14 20:29 ` [PATCH 3/5] tmem: make tmem_freeable_pages() check tmem status Doug Goldstein
2016-03-15  8:17   ` Jan Beulich
2016-03-14 20:29 ` [PATCH 4/5] tmem: don't assume stdbool.h is included Doug Goldstein
2016-03-15  8:23   ` Jan Beulich [this message]
2016-03-14 20:29 ` [PATCH 5/5] tmem: allow tmem to be disabled with Kconfig Doug Goldstein
2016-03-15  8:31   ` Jan Beulich
2016-03-15 18:28     ` Doug Goldstein
2016-03-15 19:04     ` Doug Goldstein
2016-03-16  8:36       ` Jan Beulich
2016-03-14 20:46 ` [PATCH 0/5] Allow tmem to be disabled via Kconfig Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E7D4AB02000078000DC5D9@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=cardoe@cardoe.com \
    --cc=julien.grall@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).