From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH 5/5] tmem: allow tmem to be disabled with Kconfig Date: Tue, 15 Mar 2016 13:28:59 -0500 Message-ID: <56E8546B.6060202@cardoe.com> References: <1457987365-866-1-git-send-email-cardoe@cardoe.com> <1457987365-866-6-git-send-email-cardoe@cardoe.com> <56E7D67602000078000DC5E9@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7575769749308686317==" Return-path: In-Reply-To: <56E7D67602000078000DC5E9@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Andrew Cooper , Keir Fraser , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============7575769749308686317== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2irqIpj3OKD55x5LfRcqIpGxvJna4W6fR" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2irqIpj3OKD55x5LfRcqIpGxvJna4W6fR Content-Type: multipart/mixed; boundary="K85N3phW5v7iWx4ENElxiRnqFFhbKkf7E" From: Doug Goldstein To: Jan Beulich Cc: Andrew Cooper , xen-devel@lists.xen.org, Konrad Rzeszutek Wilk , Keir Fraser Message-ID: <56E8546B.6060202@cardoe.com> Subject: Re: [PATCH 5/5] tmem: allow tmem to be disabled with Kconfig References: <1457987365-866-1-git-send-email-cardoe@cardoe.com> <1457987365-866-6-git-send-email-cardoe@cardoe.com> <56E7D67602000078000DC5E9@prv-mh.provo.novell.com> In-Reply-To: <56E7D67602000078000DC5E9@prv-mh.provo.novell.com> --K85N3phW5v7iWx4ENElxiRnqFFhbKkf7E Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/15/16 3:31 AM, Jan Beulich wrote: >>>> On 14.03.16 at 21:29, wrote: >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -5311,6 +5311,10 @@ typedef unsigned long hvm_hypercall_t( >> #define compat_grant_table_op hvm_grant_table_op_compat32 >> #define do_arch_1 paging_domctl_continuation >> =20 >> +#ifndef CONFIG_TMEM >> +#define do_tmem_op do_ni_hypercall >> +#endif >=20 > This being repeated in 3 places, wouldn't be better to put this in, > say, xen/hypercall.h, next to the function declaration? We can do this but I'd like to move the other ones from entry.S into here as well in a follow on then. --=20 Doug Goldstein --K85N3phW5v7iWx4ENElxiRnqFFhbKkf7E-- --2irqIpj3OKD55x5LfRcqIpGxvJna4W6fR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJW6FRuXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUZxEQAIwwY8rjWgRW64trhj0xVsz1 /os9ySvndzy37s+LUwm4f1egP7tJRBtKtSlsTumsII1nutpw5cSuKS92q3hWksUK WWl954YmWZKRbCrncVAv0a8NwxFf5MVw2+UNYgRd5KisI4/R1baz0k1rN28fyb6N Hho39M8w/N1w0NZSs/s8sd0+8CUZSsXWUksOGEIPggqeurkJ5hpYfj77VcFclauq IzKEqmgRDiyJLkGFojrsPBSBxUSf+n+qVQk7mcc/zI9BQV6+nTWv6zckcmOHQ8U2 er22rfu9E56wFKY4wm8HVAz1s9W/L59fYROEtsQMsEcRyFtSPAGe2ZWKcZgM83iT TSeUEbkd7Cq9khmXCjBJ7nryKpb3/5W56M1X018ayYK4JSlBE/biN3hLzrVAae4K ypaAtSqyan53HP6+kIyY2mKLwP64R4UO+N7uIlfTw7bFjButmOLgq25/vlMyJKRg 7JOqsY0Z128uMi+oJgvJxaBQ2gSEVCLAn8cqH7Icg/DIk+lUUP28/B97xX2Iztaj cU4GlXmscXKjnO4KiBGyZHs6xQ0kAkuVmAsbkcQm0fh6SwMeUYHvfSUw49iUttSL gWJKNfWf6A6kB/TiWXEHw1aY/GNfI/lET4YT7LmliFhnr/nxttGLmFqzz8BLIoQe YSepfViLGmGirlXb/9Ya =OIdK -----END PGP SIGNATURE----- --2irqIpj3OKD55x5LfRcqIpGxvJna4W6fR-- --===============7575769749308686317== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============7575769749308686317==--